Skip to content

Comments

Update Fedora build dependency#440

Closed
fwiep wants to merge 1 commit intojamulussoftware:changesfrom
fwiep:patch-1
Closed

Update Fedora build dependency#440
fwiep wants to merge 1 commit intojamulussoftware:changesfrom
fwiep:patch-1

Conversation

@fwiep
Copy link

@fwiep fwiep commented Apr 25, 2021

Does this need translation?

  • Yes

Changes

Replaced the libQt5Concurrent5 package (which is no longer available in Fedora) to qt5-qtbase, which provides the necessary libraries.


```shell
sudo dnf install qt5-qtdeclarative-devel jack-audio-connection-kit-dbus libQt5Concurrent5 jack-audio-connection-kit-devel
sudo dnf install qt5-qtdeclarative-devel jack-audio-connection-kit-dbus qt5-qtbase jack-audio-connection-kit-devel
Copy link
Contributor

@pljones pljones Apr 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't aqtinstall work for Qt on Fedora (and most platforms (edit)maybe(/edit) except Windows)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only searched for a replacement package in Fedora's standard repos. aqtinstall seems not to be in there, but qt5-qtbase is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use it for the MacOS build -- I wondered if it would save platform-specifics having to be written for the other platforms but it seems the autobuild is very platform specific still...

https://github.com/jamulussoftware/jamulus/blob/master/autobuild/mac/artifacts/autobuild_mac_1_prepare.sh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't aqtinstall work for Qt on Fedora (and most platforms (edit)maybe(/edit) except Windows)?

I can't comment regarding Mac, but I don't think we should require additional packets or scripts (?) on Linux where dependencies can be installed by the native package managers (apt, dnf, yum, etc.). At least it should be like this for users building from source and distributors. As such, it would be the best check for us to do the same in autobuild.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always thought aqtinstall was just a way of being able to install a specific version of Qt into a build environment for Mac only, so that the installation package produced would contain the version of Qt runtimes required for backward compatibility. For Fedora/CentOS/Debian/Ubuntu, there is no need for aqtinstall, because we just use the packaged version of Qt provided by the distro.

gilgongo added a commit to jamulussoftware/jamulus that referenced this pull request Apr 25, 2021
Replace qt5-qtbase with libQt5Concurrent5 as per jamulussoftware/jamuluswebsite#440
@gilgongo
Copy link
Member

This doesn't seem to be the same as the assertion about libraries here though: https://github.com/jamulussoftware/jamuluswebsite/pull/428/files

@hoffie
Copy link
Member

hoffie commented Apr 26, 2021

yum/dnf support installing by path (e.g. yum install /lib/libfoo.so). Would this help to provide a single list for all supported Fedora versions?

@gilgongo
Copy link
Member

Hi @fwiep - thanks for this. We are in fact re-writing the installation docs as part of #415 and I've incorporated these changes in that. I'll therefore close his PR, and if people want to discuss the aqtinstall stuff they are welcome to open a thread on Discussions about that.

@gilgongo gilgongo closed this Apr 30, 2021
@fwiep fwiep deleted the patch-1 branch April 30, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants