Update Fedora build dependency#440
Update Fedora build dependency#440fwiep wants to merge 1 commit intojamulussoftware:changesfrom fwiep:patch-1
Conversation
|
|
||
| ```shell | ||
| sudo dnf install qt5-qtdeclarative-devel jack-audio-connection-kit-dbus libQt5Concurrent5 jack-audio-connection-kit-devel | ||
| sudo dnf install qt5-qtdeclarative-devel jack-audio-connection-kit-dbus qt5-qtbase jack-audio-connection-kit-devel |
There was a problem hiding this comment.
Doesn't aqtinstall work for Qt on Fedora (and most platforms (edit)maybe(/edit) except Windows)?
There was a problem hiding this comment.
I have only searched for a replacement package in Fedora's standard repos. aqtinstall seems not to be in there, but qt5-qtbase is.
There was a problem hiding this comment.
We use it for the MacOS build -- I wondered if it would save platform-specifics having to be written for the other platforms but it seems the autobuild is very platform specific still...
There was a problem hiding this comment.
Doesn't
aqtinstallwork for Qt on Fedora (and most platforms (edit)maybe(/edit) except Windows)?
I can't comment regarding Mac, but I don't think we should require additional packets or scripts (?) on Linux where dependencies can be installed by the native package managers (apt, dnf, yum, etc.). At least it should be like this for users building from source and distributors. As such, it would be the best check for us to do the same in autobuild.
There was a problem hiding this comment.
I always thought aqtinstall was just a way of being able to install a specific version of Qt into a build environment for Mac only, so that the installation package produced would contain the version of Qt runtimes required for backward compatibility. For Fedora/CentOS/Debian/Ubuntu, there is no need for aqtinstall, because we just use the packaged version of Qt provided by the distro.
Replace qt5-qtbase with libQt5Concurrent5 as per jamulussoftware/jamuluswebsite#440
|
This doesn't seem to be the same as the assertion about libraries here though: https://github.com/jamulussoftware/jamuluswebsite/pull/428/files |
|
yum/dnf support installing by path (e.g. |
Does this need translation?
Changes
Replaced the
libQt5Concurrent5package (which is no longer available in Fedora) toqt5-qtbase, which provides the necessary libraries.