Start page: Add download links for 3.7.0#365
Merged
hoffie merged 2 commits intojamulussoftware:releasefrom Mar 17, 2021
Merged
Conversation
ann0see
requested changes
Mar 17, 2021
1-de-index.html
Outdated
| mTSlogan: "Musiziere online. Mit deinen Freunden. Kostenlos." | ||
| mTGetStartedNow: "Jetzt Starten!" | ||
| mHTMLDownloadNow: 'Erweitert: <a href="https://sourceforge.net/projects/llcon/files/latest/download" target="_blank" id="dld_frm_sf" rel="noreferrer">sofort herunterladen</a>' | ||
| mHTMLDownloadNow: 'Sofort herunterladen für <a href="https://github.com/jamulussoftware/jamulus/releases/download/r3_7_0/jamulus_3.7.0_win.exe" target="_blank" rel="noreferrer">Windows</a>, <a href="https://github.com/jamulussoftware/jamulus/releases/download/r3_7_0/jamulus_3.7.0_mac.dmg" target="_blank" rel="noreferrer">Mac</a>, <a href="https://github.com/jamulussoftware/jamulus/releases/download/r3_7_0/jamulus_3.7.0_ubuntu_amd64.deb" target="_blank" rel="noreferrer">Debian/Ubuntu</a> or <a href="https://github.com/jamulussoftware/jamulus/releases/tag/r3_7_0" target="_blank" rel="noreferrer">andere Plattformen</a>.' |
Member
There was a problem hiding this comment.
I think you should use the Jekyll variables here (see the wiki/en/*Installation-For* files
Member
Author
There was a problem hiding this comment.
Using these variables broke the site because they are not expanded in front matter. :(
https://fettblog.eu/snippets/jekyll/liquid-in-frontmatter/
I chose a different approach in #366 now.
hoffie
force-pushed
the
download-links-3.7.0
branch
from
34c5ad4 to
5d192dc
Compare
pljones
reviewed
Mar 17, 2021
This replaces the SourceForge link to platform-specific direct links on Github for better usability. This requires text changes. To avoid delaying the release further, it was decided to not run those texts through translators again. This could still be updated post-release, of course. This required CSS changes because the styling was previously specified for a single link identified by an id=. This obviously breaks with multiple links. Fixes jamulussoftware#359.
hoffie
force-pushed
the
download-links-3.7.0
branch
from
5d192dc to
1a920fe
Compare
pljones
approved these changes
Mar 17, 2021
Member
Author
|
This PR broke the URLs and I have reverted by directly pushing to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start page: Add download links for 3.7.0
This replaces the SourceForge link to platform-specific direct links on Github for better usability.
This requires text changes. To avoid delaying the release further, it was decided to not run those texts through translators again.
This could still be updated post-release, of course.
This required CSS changes because the styling was previously specified for a single link identified by an id=. This obviously breaks with multiple links.
Fixes #359.
This also cleans up the CSS which contained duplicate definitions.
Preview (with home.css replaced and the HTML edited): https://hoffmann-christian.info/files/2021-03-17-jamulus.io.html
Might be easier to review if checking the two commits individually.