Skip to content

Comments

Add GitHub actions binary links to config.yml file#308

Merged
ann0see merged 3 commits intochangesfrom
Binary
Feb 17, 2021
Merged

Add GitHub actions binary links to config.yml file#308
ann0see merged 3 commits intochangesfrom
Binary

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Feb 17, 2021

Solves: #307

Probably still worth a discussion. This is a quick and easy approach.

@ann0see ann0see linked an issue Feb 17, 2021 that may be closed by this pull request
@@ -10,7 +10,8 @@ permalink: "/wiki/Installation-for-Windows"
# Installation for Windows
Make sure you read the [Getting Started](Getting-Started) page.
1. **Download and install an ASIO Driver**. It is recommended to use a sound card/interface with a native ASIO driver. If you don't have an external sound card, you probably need to install [this free ASIO driver (ASIO4ALL)](https://www.asio4all.org){: target="_blank" rel="noopener noreferrer"} before installing Jamulus.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this also note that "It's well worth installing the ASIO4ALL Off-line Settings tool when installing ASIO4ALL", as well? It lets people set up before running Jamulus - i.e. not having Jamulus make wrong decisions about what devices are available. Indeed, I'd even say this is the point to say "If you're installing ASIO4ALL and haven't used it before - go read this" and link to something that will explain what's going on... Once we have it.

Copy link
Member Author

@ann0see ann0see Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're installing ASIO4ALL and haven't used it before - go read this

Yes. That's a good suggestion. Can you open a PR to the changes branch with this proposal?

Concerning the off-line settings, I'm not exactly sure if that helps. I think there was a discussion somewhere that it doesn't do what we thought it would do: You can't setup the A4A in/outputs with off line settings since A4A saves configuration on per app basis.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't setup the A4A in/outputs with off line settings since A4A saves configuration on per app basis.

Oh - OK, no point then, agreed. I wonder why it exists? (Maybe that's why it's so hard to install....)

Copy link
Contributor

@pljones pljones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this shouldn't be merged until after the latest tag gets moved?

@ann0see
Copy link
Member Author

ann0see commented Feb 17, 2021

So this shouldn't be merged until after the latest tag gets moved?

Yes it should! If we merge it to changes, it will not go live instantly. jamulus.io is built on the files on the release branch. Once a Jamulus release is planned, release will be merged into translate and once the translations are finished and Jamulus gets released, translate will be merged into release which then "publishes" the site.

@pljones
Copy link
Contributor

pljones commented Feb 17, 2021

Ah, right... Is there a document for maintaining the jamuluswebsite, i.e. with the process needed to make changes and release them? (Not related to this, of course.)

@ann0see
Copy link
Member Author

ann0see commented Feb 17, 2021

Not exactly, but see https://github.com/jamulussoftware/jamuluswebsite/blob/changes/CONTRIBUTING.md and probably #31 and #14

But information seems to be cluttered everywhere.

@ann0see ann0see merged commit 9ae26ff into changes Feb 17, 2021
@ann0see ann0see deleted the Binary branch February 17, 2021 19:06
@ann0see
Copy link
Member Author

ann0see commented Feb 17, 2021

Merged. Sure, we might need to move to another solution soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] How should we handle binary files from Autobuild?

2 participants