Conversation
CONTRIBUTING.md
Outdated
|
|
||
| If that's not the case, please open a [new issue](https://github.com/jamulussoftware/jamuluswebsite/issues/new/choose), select which type of issue it is and describe your issue. | ||
|
|
||
| If you want to open a Pull Request (after having described and discussed your proposal), have a look at the [Contribution page on the website](https://jamulus.io/wiki/Contribution). Keep in mind that your changes (if they are not just typos) might have to wait until everything is translated. We will bundle them (if everything is allright) with other changes and upload multiple changes in one bulk to jamulus.io. |
There was a problem hiding this comment.
Do we really want to link this page? I don't feel comfortable by doing so. In fact, we should link this file on the mentioned site not the other way round, I think
There was a problem hiding this comment.
we should link this file on the mentioned site not the other way round, I think
I think too.
There was a problem hiding this comment.
What does "please subscribe to the issue" mean?
There was a problem hiding this comment.
Yes, but why do we ask them to do this? It seems oddly specific.
There was a problem hiding this comment.
I think it's since a user will then be able to receive updates on this issue. If you want to remove it, just do so.
There was a problem hiding this comment.
I think it's since a user will then be able to receive updates on this issue. If you want to remove it, just do so.
Sorry, I wasn't online last night.
I'll let you decide (it seems to be updated), it's not necessarily useful to keep it.
CONTRIBUTING.md
Outdated
|
|
||
| If you want to open a Pull Request (after having described and discussed your proposal), have a look at the [Contribution page on the website](https://jamulus.io/wiki/Contribution). Keep in mind that your changes (if they are not just typos) might have to wait until everything is translated. We will bundle them (if everything is allright) with other changes and upload multiple changes in one bulk to jamulus.io. | ||
|
|
||
| ## I don't know GitHub. What do I need to know? |
There was a problem hiding this comment.
This could go to the website
There was a problem hiding this comment.
Any thoughts on this? I've moved some files on the website but I'm not sure if that isn't too much. (also removed a few SourceForge references since I think to make the line between development and Forum clearer, most feature requests should go to github)
| Please note that discussions should be kept in English. Don't be afraid, if you don't speak English fluently. You can use [DeepL](https://www.deepl.com) which might be able to translate your language to English. | ||
|
|
||
| ## Branches, Translation and development process | ||
|
|
There was a problem hiding this comment.
I hope this is clear now. We might need to clarify our process.
|
How do I actually see this file using Jeckyl? I can't really assess it in Github. |
|
No, you can't. You need to access it via https://github.com/jamulussoftware/jamuluswebsite/blob/upd_contribute/CONTRIBUTING.md |
Deepl is quite good. But we can of course link a few other pages. |
I know it is (I use it quite often myself). What makes me uncomfortable is to promote only one of them when there are alternatives, some of which are also very good and are improving (they are moving more and more to AI). |
|
Yes. You're right. I've integrated your proposal now. |
|
Awesome, thanks. |
gilgongo
left a comment
gilgongo
left a comment
There was a problem hiding this comment.
You can make this live I guess, but it's in such a different written style and structure to the rest of the site - it really needs to be re-written in my opinion. And even then it makes the whole contribution process look really complicated if you ask me.
Are you sure about that? We will start the translation period as soon as gilgongo opens and merges the pr to translation. Every change until this will be included in the next version. |
|
Sorry I meant we can merge this. But really I'd prefer not to because I think it's on the wrong track. Confronting people with a big bunch of complex rules isn't going to encourage much contribution. Just tell them to post on the issues list and we can take it from there. |
|
Agree. Nevertheless we must at least make all the branches stuff clear. So this PR will not be merged for the next version. |
gegeweb
left a comment
gegeweb
left a comment
There was a problem hiding this comment.
Seems good to me.
Thanks!
|
I would maybe remove the "I don't know GitHub. What do I need to know?" which is shown on the website. Any thoughts on this? |
CONTRIBUTING.md
Outdated
|
|
||
| After having discussed and agreed on changes you want to be integrated to jamulus.io, you should ask yourself some questions: | ||
|
|
||
| ## 0. Is the language of your content already online and existing? |
There was a problem hiding this comment.
"Is your content in a language that already exists on the site?" This reads a bit better.
CONTRIBUTING.md
Outdated
| After having discussed and agreed on changes you want to be integrated to jamulus.io, you should ask yourself some questions: | ||
|
|
||
| ## 0. Is the language of your content already online and existing? | ||
| No: Will discuss this later (since you introduce a new language). |
There was a problem hiding this comment.
This No: " "Yes: " style is a bit weird, particularly as we don't use it in the section above. I'd keep it to "If not..." and "If so..." really. It's also slightly ambiguous: "No: A fix which doesn't need to be translated" could be taken to mean "Don't make a fix that doesn't need to be translated". It's just odd!
README.md
Outdated
| Built with Jekyll and Fox-CSS | ||
| This is the home of the [Jamulus website](https://jamulus.io). The goal of this page is to explain what Jamulus is and how to use it. | ||
|
|
||
| ## Contribute and translation |
There was a problem hiding this comment.
"Contribute a translation"?
Wait - none of this stuff is here: https://github.com/jamulussoftware/jamuluswebsite/blob/upd_contribute/CONTRIBUTING.md
I'm confused by GitHub again... Giving up.
There was a problem hiding this comment.
Don't give up! These are in total 3 files. The file you saw here is the README file which links to the contributing file.
There was a problem hiding this comment.
Yes,
Contribute a translation
is better since we talk about translation afterwards.
|
I think, we should merge this and then do some changes afterwards. What do you think? |
|
I might not be available in the next few days. @gilgongo and others free to merge/modify my PRs (especially this one). The next steps would then be to look through the wiki to fix syntax errors and typos. @ignotus666 wanted to do that. |
|
I'll see if I can do it this coming week. |
|
I will merge this in a few minutes and then we can discuss more of it |
|
@gilgongo now reviewing it should be easier since it's on the changes branch |
* [gen] Add community section (#101) * First blog beta * non working blog pagination * small fix * Revert "small fix" This reverts commit d527efc. * Add example blog * clarify github * Fix heading * Add structured data * add structured data * First try GH comment api * Revert "First try GH comment api" This reverts commit 0ad04d8. * Remove blog posts * Add dates * add authors * Add more pages * add pagination to bottom of posts * Fix issues and add example draft * Rename blog to knowledge base * Remove german translation since it's not wanted * Add discussion url * move some files * Update 2020-03-28-Example-Setup-Hardware.md * Remove SW Synth to re-add it * Add Software Synth by @niebert * Update 2020-12-10-Software-Synth.md * First review * Second review * Remove install script to re add it via pr * Minor improvements * Use @trebmuh changes * Beautify * Added pictures * Update 2020-10-19-Software-Synth.md * Update 2020-10-19-Software-Synth.md * Fixed screenshot * rename blog folder to kb * Update 2020-09-20-Linux-Install-Script.md * smaller bugfixes * Dirty fix for nav kb * small changes * Add review changes Co-authored-by: Olivier Humbert <[email protected]> Co-authored-by: ignotus <[email protected]> * Update en-Compiling.md * Update fr-Compiling.md * Update de-Compiling.md * Update es-Compiling.md * W: [fr] fr-Tips-Tricks-More.md (#122) (#193) * Link to the CC french version * GNU/Linux -> Linux (keep close to EN!) * W: [fr] fr-Tips-Tricks-More.mdd * [fr] fr-Tips-Tricks-More update Co-authored-by: Olivier Humbert <[email protected]> Co-authored-by: Gérald Niel <[email protected]> Co-authored-by: Olivier Humbert <[email protected]> * Fix a link * Move Raspi page * add new line * redirect pages * Fix a typo (#195) Co-authored-by: ann0see <[email protected]> * remove draft * Add gen reccom * Update en-Getting-Started.md * Fix a few qjackctl * fix a few jack --> JACK * fix macbook --> MacBook and firewire --> FireWire * consistent ASIO4ALL * Add trombonepizza link to user profile * Update en-Getting-Started.md * [fr] Create fr-Network-Requirements.md (#112) (#197) * W: [fr] fr-Network-Requirements.md * Update fr-Network-Requirement.md * [fr] update fr-Network-Requirements.md Co-authored-by: Olivier Humbert <[email protected]> Co-authored-by: Gérald Niel <[email protected]> Co-authored-by: Olivier Humbert <[email protected]> * [fr] Network-Requirements: fixes a broken link (#198) (#199) Co-authored-by: Olivier Humbert <[email protected]> * Avoid repetition: fix redundant link. * Let's match the title of the linked page. (#200) (#202) Co-authored-by: Gérald Niel <[email protected]> * Add @gegeweb rec * [fr] fr-Server-Troubleshooting.md (#145) (#203) * W: [fr] fr-Server-Troubleshooting.md * [fr] update fr-Server-Troubleshooting.md Co-authored-by: Olivier Humbert <[email protected]> Co-authored-by: Gérald Niel <[email protected]> Co-authored-by: Olivier Humbert <[email protected]> * a few small typos fixed * fix a few sounddevices * W: [fr] fr-Server-Win-Mac.md (#119) (#205) * W: [fr] fr-Server-Win-Mac.md * [fr] update fr-Server-Win-Mac.md Co-authored-by: Olivier Humbert <[email protected]> Co-authored-by: Gérald Niel <[email protected]> Co-authored-by: Olivier Humbert <[email protected]> * Make the download more prominent * Get closer to english (#206) Co-authored-by: ann0see <[email protected]> * [fr] Create fr-Choosing-a-Server-Type.md (#115) (#207) * W: [fr] fr-Choosing-a-Server-Type.md * Little rewording, ready for review. * [fr] update fr-Choosing-a-Server-Type.md Co-authored-by: Olivier Humbert <[email protected]> Co-authored-by: Gérald Niel <[email protected]> Co-authored-by: Olivier Humbert <[email protected]> * W: [fr] fr-Running-a-Private-Server.md (#116) (#208) * W: [fr] fr-Running-a-Private-Server.md * [fr] fr-Running-a-Private-Server.md update Co-authored-by: Olivier Humbert <[email protected]> Co-authored-by: Gérald Niel <[email protected]> Co-authored-by: Olivier Humbert <[email protected]> * uncomment kb * [en] consistency: Internet speed not clear: MBit/s, Mbps,... (#204) * MBit/s * kbps --> Kbit/s * consistency * add spaces * add more spaces * remove some target blank * fix syntax * add anc to compiling os * W: [fr] fr-Hardware-Setup.md (#117) (#209) * W: [fr] fr-Hardware-Setup.md * Update fr-Hardware-Setup.md Co-authored-by: Olivier Humbert <[email protected]> Co-authored-by: Gérald Niel <[email protected]> Co-authored-by: Olivier Humbert <[email protected]> * W: [fr] fr-Server-Linux.md (#118) (#212) * W: [fr] fr-Server-Linux.md * [fr] update fr-Server-Linux.md Co-authored-by: Olivier Humbert <[email protected]> Co-authored-by: Gérald Niel <[email protected]> Co-authored-by: Olivier Humbert <[email protected]> * Add link to ASIO4ALL manual * Update de-Contribution.md (#214) Co-authored-by: ann0see <[email protected]> * Update de-Installation-for-Windows.md * Update de-Getting-Started.md (#215) Co-authored-by: ann0see <[email protected]> * Update CONTRIBUTING files (#157) * Add new contributing file * Clarify branches * Moved a bit to homepage * Review updates * fix typo * Grammar * Add more translation services * fix a few issues * small fix * Add github * Update README * @ignotus666 changes * Wording * ignotus rechnet * gilgongo fix * Update CONTRIBUTING.md * Update README.md * Update README.md * Update README.md * Update 2020-11-24-Multiple-Audio-Interfaces.md * Update en-Installation-for-Linux.md * [en] en-Compiling.md (consistency: QT -> Qt) * [fr] consistency: jack Jack JACK (#219) (#221) * Update fr-Software-Manual.md * Update fr-Command-Line-Options.md * Update fr-Installation-for-Linux.md Co-authored-by: Olivier Humbert <[email protected]> * Change some texts on the homepage (#217) * Small changes with SEO in mind Jamulus is currently bad at SEO. I think we could improve the wording here. * Update 1-index.html * [en] QjackCtl spelling (2020-11-24-Multiple-Audio-Interfaces.md) * [en] QjackCtl spelling (en-Hardware-Setup.md) * [fr] typo fix Berhinger/Behringer (#224) (#225) Co-authored-by: Olivier Humbert <[email protected]> * [fr] démonstrations -> démos (#226) (#227) * [fr] update fr-Demos.md (démonstrations -> démos) * [fr] update navigation.yml (démonstrations -> démos) Co-authored-by: Olivier Humbert <[email protected]> * [fr] consistency: Internet -> internet (#228) (#229) * [fr] consistency: Internet -> internet (1-fr-index.html) * [fr] consistency: Internet -> internet (fr-Getting-Started.md) * [fr] consistency: Internet -> internet (fr-Client-Troubleshooting.md) * [fr] consistency: Internet -> internet (fr-Demos.md) Co-authored-by: Olivier Humbert <[email protected]> * [en] consistency alsa -> ALSA (2020-11-24-Multiple-Audio-Interfaces.md) * Add Debian packages * A few changes (#210) * Add some small changes * remove duplicate * sync mac and windows * Update en-Installation-for-Windows.md * Remove compilation link since it might confuse people * Remove scroll down since there's nothing below * Change MacOS to macOS * Update en-Installation-for-Windows.md * Update it-Getting-Started.md (#230) Some small correction plus the main one: the meaning of footnote 1 was reversed in Italian. * [en] consistency Macintosh->macOS (en-Server-Linux.md) * Explain how the new installer can be compiled This will show how to compile the new installer on Windows. Have a look at the discussion in jamulussoftware/jamulus#792 * Quote the directory name as code * Create newsounddevice.md * Create 2021-01-05-Jamulus-Sound-Devices.md * Move Sound Devices to community KB * Structure sound devices by OS * Update 2021-01-05-Jamulus-Sound-Devices.md * Add more detail for Windows build process * Fix formatting * Add Qt versioning info * Small edit * Add tested Behringer XENYX X1832 USB Thanks to @achim-grosse-oetringhaus #223 * Update en-Sound-Devices.md (#223) Added Behringer XENYX 1832 USB Co-authored-by: ann0see <[email protected]> * [fr] links fixes (fr-Server-Win-Mac.md) (#235) (#236) Co-authored-by: Olivier Humbert <[email protected]> * [fr] update 1-fr-index.html (#238) (#239) * [fr] update fr-Command-Line-Options.md (#240) (#241) Co-authored-by: Olivier Humbert <[email protected]> * Since GH Action fails remove CI (#243) Co-authored-by: ann0see <[email protected]> * French translation update (#245) (#247) * [en] update en-Compiling.md (steinberg link in EN) (#244) (#246) * Add contributors * Add qjackctl * French l10n update (#248) (#249) * [fr] update fr-Onboarding.md * [fr] update fr-Installation-for-Windows.md * [fr] update fr-Installation-for-Macintosh.md * [fr] update fr-Installation-for-Linux.md Co-authored-by: Olivier Humbert <[email protected]> * Link quoting issue * ASIO description (#242) * Add ASIO description Since the new installer will link to this page, a description of ASIO is needed * Grammar mistake fixed * Add ASIO heading (#251) * [fr] links fixes (fr-Server-Win-Mac.md) (#235) * [fr] update 1-fr-index.html (#238) * [fr] update fr-Command-Line-Options.md (#240) * Since GH Action fails remove CI * French translation update (#245) * [en] update en-Compiling.md (steinberg link in EN) (#244) * French l10n update (#248) * [fr] update fr-Onboarding.md * [fr] update fr-Installation-for-Windows.md * [fr] update fr-Installation-for-Macintosh.md * [fr] update fr-Installation-for-Linux.md * Add small changes to link ASIO from new installer * Update en-Installation-for-Windows.md Co-authored-by: Olivier Humbert <[email protected]> * French l10v improvements (#253) (#254) * French l10n improvements (#257) (#258) * Re Add jekyll CI * Review changes * updates/fixes a link * Clarify the .deb package installation * [en] update footertext.md closes #255 * Checking spelling and grammar * Delete cherrypick.yml * Create syncbranches.yml * Sync on release merge only * Sync md style * Revert slogan to make music Reference: jamulussoftware/jamulus#861 (comment) * Update hosts list and explanation * Add note about ProtectHome As per forum discussion on saving recordings. * Correct typos, spelling * Make Gemfile.lock writable * Pull request test (#277) Does the build script only work with pull requests? * Pull request previously non-building version (#278) * Add GUI instructions * Add more prominent ASIO4ALL link and changes * Make --> Play * Apply suggestions from @mulyaj * fixed typo * wiki/Command-Line-Options: document --serverpublicip jamulussoftware/jamulus#954 Signed-off-by: Christian Hoffmann <[email protected]> * Changed body text colour - 000 to 333 * Update en-Central-Servers.md * Update en-Client-Troubleshooting.md * Update en-Compiling.md * Update en-Contribution.md * Update en-Getting-Started.md * Update en-Hardware-Setup.md * Update en-Installation-for-Linux.md * Update en-Installation-for-Macintosh.md * Update en-Installation-for-Windows.md * Update en-Network-Requirements.md * Update en-Onboarding.md * Update en-Privacy-Statement.md * Update en-Running-a-Private-Server.md * Update en-Running-a-Server.md * Update en-Server-Linux.md * Update en-Server-Troubleshooting.md * Update en-Server-Win-Mac.md * Update en-Software-Manual.md * Update en-Tips-Tricks-More.md * Update en-Central-Servers.md * Update en-Contribution.md * Add spacing * Update en-Client-Troubleshooting.md * Add --listfilter documentation Will also create link to this from Configuration page. * Remove premature change Sorry! Non-English changes directly on the changes branch cause chaos. * Use "involved" As per #279 (comment) Also added FOSS as per #163 * Create image library * Multi-lingual screenshots * Update image path Images now in en-screenshots to allow multi-lingual. * Fix broken link * Clarify translation (#288) * Add new linux installation * Update it footer * Add basic android guide * Update general.yml * Change beta to PoC * Revert "Update" * Apply changes from review * Apply clarification * Update en-Hardware-Setup.md * Update en-Installation-for-Windows.md * Update en-Onboarding.md * Update en-Onboarding.md * Update en-Software-Manual.md * Corrected URL * Corrected URL * Corrected URL * Better local monitoring test From [Chris Rimple](https://sourceforge.net/p/llcon/discussion/software/thread/166288d63e/#e047) * Updated to document new MIDI controller functions * Updated MIDI controller syntax * Update en-Command-Line-Options.md * Correction and addition * Update en-Installation-for-Linux.md * Removed spaces * Link --serverpublicip desc. to docs (#290) * Link --serverpublicip desc. to docs As per jamulussoftware/jamulus#954 (comment) * Update en-Command-Line-Options.md * Removed spaces * Correction * Correction * Update * Some rephrasing * Just realised the next release will be 3.7.0 * Remove donation implication Also BE spelling for licence * Install deb via apt * Add flatpak and other instructions * Move debian testing down * Add jump marker * Add headless server .deb instruction * Add link to deb file * Add direct link to deb file * Add configuration of headless server * Add daemon-reload * Breadcrumb (#306) * Add breadcrumb style * Create breadcrumb.html * Update breadcrumb.html * Update en-Central-Servers.md * Update en-Choosing-a-Server-Type.md * Update en-Installation-for-Windows.md * Update en-Installation-for-Macintosh.md * Update en-Installation-for-Linux.md * Update en-Hardware-Setup.md * Update en-Running-a-Private-Server.md * Update en-Server-Linux.md * Update en-Server-Troubleshooting.md * Update en-Server-Win-Mac.md * is will be -> is * Update en-Tips-Tricks-More.md * Fix grammar mistake * Change quoting @gilgongo could you please verify if this works as expected? * Update link * Add binary links via config.yml file * Add link to headless deb on server page * Move corrados to jamulussoftware * Fix broken ASIO4ALL manual link * Remove ASIO4ALL manual link @pljones I hope that's ok now * Add breadcrumb * URL updates, admin page * Add debian buster backports Co-authored-by: ann0see <[email protected]> Co-authored-by: Olivier Humbert <[email protected]> Co-authored-by: ignotus <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gérald Niel <[email protected]> Co-authored-by: vdellamea <[email protected]> Co-authored-by: jdrage <[email protected]> Co-authored-by: achim-grosse-oetringhaus <[email protected]> Co-authored-by: ann0see <[email protected]> Co-authored-by: mulyaj <[email protected]> Co-authored-by: Christian Hoffmann <[email protected]> Co-authored-by: Peter L Jones <[email protected]> Co-authored-by: dzpex <[email protected]>
5 participants
As discussed in #59 I've now added the proposal from @gegeweb to a new contributing file.