Settings UI changes for ASIO#999
Conversation
New function SetMixerBoardDeco sets title color and background according to recording state and skin. Called on recorder state change, skin change and disconnect
…questTemplate Add feature request template
…odules-to-ssh Move submodules to relative paths
…server-recording feature-req925 recording indicator
Added myself to contributor list
Update ChangeLog for jamulussoftware#968
The relative paths in .gitmodules contained a stray github.com/ path component which broke submodule resolution. Got broken in jamulussoftware#934 Fixes jamulussoftware#984 Signed-off-by: Christian Hoffmann <[email protected]>
Fix git submodule usage (which I - pljones - broke...)
Embedded quotes were included in strings by doubling them: `""` This doesn't work in C++, so changed to `\"`
Also warn when this option is used when not running in server mode or when not registering to a central server. Signed-off-by: Christian Hoffmann <[email protected]>
…icip-logging Add logging for --serverpublicip
Fix bad embedded quotes in strings.
update repo
Add current ASIO changes
|
@mulyaj I think you need to open this PR based on the MoveASIO branch not on master. |
|
Yeah I did something wrong here... can you remove this? |
|
Wait a moment, I'll try to do a git cherry-pick here. |
|
I'm not sure how to just get the .UI and .cpp changes I made to PR. |
|
This happens because these changes are based on master and the MoveASIO branch is not up to date with master. Let me check it. |
|
Oh I merged master accidentally, I see. Thanks. |
|
See #1000 |
|
Cool! Appreciate it. |
|
Just merged it. I assume this is your first PR here? Thank you very much ;-)! You should add yourself to the contributor list. I'll link to it shortly. |
|
Ok. You should add yourself to this file now: https://github.com/jamulussoftware/jamulus/blob/master/src/util.cpp Just add the main repo via
Then do your changes, push it and open a PR here. |
|
Ok, will do |
7 participants
Renamed "ASIO Setup" to "ASIO Device Settings" and created a QTgroupbox for devices.