Fix bad embedded quotes in strings.#989
Conversation
Embedded quotes were included in strings by doubling them: `""` This doesn't work in C++, so changed to `\"`
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
From my first impression, everything seems to be ok.
| // prepare update check info label (invisible by default) | ||
| lblUpdateCheck->setText ( "<font color=""red""><b>" + QString ( APP_NAME ) + " " + | ||
| lblUpdateCheck->setText ( "<font color=\"red\"><b>" + QString ( APP_NAME ) + " " + | ||
| tr ( "software upgrade available" ) + "</b></font>" ); |
There was a problem hiding this comment.
Probably worth another issue, but I think, this should be changed to something like "software upgrade available. Install the new version from the website."
pljones
left a comment
pljones
left a comment
There was a problem hiding this comment.
I'm assuming there's a reason the .qm files are there.
Yes: see: #989 (comment) Once we do a new release, these files will probably need to be recreated. I saw that in the debian repo, some improvements have been made to this: https://sources.debian.org/patches/jamulus/3.6.2+dfsg1-2/use-lrelease.diff/ I will merge this now. |
The .qm files are generated from the .ts files, but there are no Makefile rules to do that (not sure why not) - it's a manual process by running |
4 participants
Embedded quotes were included in strings by doubling them:
""This doesn't work in C++, so changed to
\"