unified autobuild github-action by nefarius2001 · Pull Request #978 · jamulussoftware/jamulus

nefarius2001 · 2021-02-10T22:13:43Z

Work for #854:
single workflow

compiling on all platforms, including codeQL where possible => nice check for each PR
separate codeQL-builds where necessary
upload packs/binaries/installers as artifacts of the job (autodelete after 31 days) => low barrier for testing features on different platforms
upload packs/binaries/installers to releases if triggered by tags starting with "r_" << still needs small tweaking
updating packs/binaries/installers in a special release if triggered by tag named "latest" << still needs small tweaking

Fixes jamulussoftware#859

This will support macOS < 10.13. Fixes jamulussoftware#959

ann0see · 2021-02-10T22:16:32Z

Thank you very much for your work again ;-). Can you also include #964?

Edit: seems we had the exact same idea ;-).

nefarius2001 · 2021-02-10T22:48:35Z

Sure. See the merge here: https://github.com/nefarius2001/jamulus/tree/autobuild_head

See original source: https://sourceforge.net/p/nsis/code/HEAD/tree/NSIS/trunk/COPYING

nefarius2001 · 2021-02-11T21:56:34Z

will need #962

… autobuild_head

…uild_head

- consistently in three steps: prepare-build-copy - artifacts stored for limited amout of days with the github-action-run - files named by githash/release - auto-creation of releases

nefarius2001 · 2021-02-13T01:37:30Z

Finally, my work is done!

One open question: currently a pull request triggers code-QL warnings ("Please make sure that every branch in on.pull_request is also in on.push so that Code Scanning can compare pull requests against the state of the base branch")
Personally, I'd add "push.master" as a trigger as well, but in the discussion #854 being resourceful was highly empasised, too.

For proof of working, see:
https://github.com/nefarius2001/jamulus/releases
https://github.com/nefarius2001/jamulus/actions

checks will likely need retriggering, when the submodule issue is solved

pljones · 2021-02-13T09:27:49Z

Hm. Might need another rebase to pick up the submodule changes, I'm afraid.

nefarius2001 · 2021-02-13T09:39:40Z

Repeating the action would suffice, can someone click „rerun all jobs“ please?

pljones · 2021-02-13T10:20:18Z

I did. It failed the same. Hence suggesting a rebase might help.

hoffie · 2021-02-13T10:22:17Z

I think the rebase on master is required in order to have #985 included in this PR.

…d/stable2

nefarius2001 · 2021-02-13T15:31:13Z

I used a normal merge... less effort since i merged ann0see's contributions earlier

ann0see

First a few overview. I'll look into the functionality soon.

.github/workflows/autobuild.yml

ann0see · 2021-02-13T15:38:01Z

.github/workflows/autobuild.yml

+        if:                         ${{ matrix.config.cmd1_prebuild }}
+        run:                        ${{ matrix.config.cmd1_prebuild }}
+        env:
+          ACTIONS_ALLOW_UNSECURE_COMMANDS: 'true'  # allow setting environment variables


Sounds a bit dangerous. Can't you just output environment variables via echo?

this allos the use of ::set-env name=xxxxxx::${xxxxxxx}

My problem was that autobuild_apk_1_prepare.sh sets a lot of variables, and I dont know which ones are necessary for building then. Doint special treatment for 15 variables via output and mentioning them as environment of next step is not clean any more. I'm open for suggestions.

Hmm. If you think this is the best way to do it, I would just leave it like that for now.

.github/workflows/autobuild.yml

windows/autobuild/autobuild_windowsinstaller_1_prepare.ps1

windows/autobuild/autobuild_windowsinstaller_2_build.ps1

windows/autobuild/autobuild_windowsinstaller_3_copy_files.ps1

windows/deploy_windows.ps1

ann0see

Almost finished. Will look into changing a few things here (and I'll update the branch to the current master branch because of the broken headless build). Afterwards I'll do a new beta release.

.github/workflows/autobuild.yml

autobuild/android/autobuild_apk_1_prepare.sh

autobuild/android/install-qt.sh

autobuild/linux/autobuild_deb_2_build.sh

autobuild/mac/artifacts/autobuild_mac_2_build.sh

ann0see · 2021-02-18T16:09:57Z

autobuild/mac/codeQL/autobuild_mac_1_prepare.sh

+###################
+
+echo "Install dependencies..."
+brew install qt5


Todo (not blocking): use aqt and the same process as in the release process.

There should only be one "Install Qt" (per platform). If it's always needed, always run it (as a workflow step). One workflow. Some steps always run (i.e. those that prepare for what happens later). Some steps only run under certain conditions (branch name, action, target - CodeQL only runs sometimes, publish only runs sometimes).

("target" - this doesn't just mean platform, it includes combinations like "headless server on debian x64".)

autobuild/windows/autobuild_windowsinstaller_1_prepare.ps1

distributions/io.jamulus.Jamulus.prepare.py

ann0see

Aside from the slow CodeQl build, I'd say this is ready once the comments above are answered. There are still some open points, but they're not part of this PR (nefarius2001#6). Therefore I'll approve this. After this (or even now) I think, we could even try it by releasing a new version of Jamulus?

autobuild/android/autobuild_apk_1_prepare.sh

autobuild/ensure_THIS_JAMULUS_PROJECT_PATH.sh

autobuild/linux/autobuild_deb_1_prepare.sh

autobuild/mac/artifacts/autobuild_mac_1_prepare.sh

pljones · 2021-02-18T19:26:53Z

autobuild/mac/codeQL/autobuild_mac_2_build.sh

+
+
+echo "Building... qmake"
+if [-x /Users/runner/work/jamulus/jamulus/Qt/5.15.2/clang_64/bin/qmake]


Did you try it without specifying the full path like this? I found it worked just doing qmake, after running the install in the CodeQL workflow. If it does, it would make it less painful moving from 5.15.2 to 5.9 for the MacOS build.

autobuild/mac/codeQL/autobuild_mac_3_copy_files.sh

pljones · 2021-02-18T20:01:35Z

I think there's more to do - but it can wait till after this gets merged. Continuous Improvement means taking "good enough" and making it better, later. This is definitely good enough and better that we have.

pljones · 2021-02-18T20:02:52Z

#964 though. Is that covered?

ann0see · 2021-02-18T20:03:14Z

Yes. This is included as far as I know.

ann0see · 2021-02-18T20:09:05Z

@pljones I'd wait a bit until @nefarius2001 is finished and afterwards, you can merge it.

pljones · 2021-02-18T20:42:02Z

Yes. This is included as far as I know.

Ah - the confusion is around the CodeQL vs main build - one uses 5.12.2, the other 5.9.9. That can wait (we've been using 5.12.2 for CodeQL up until now) but needs fixing, as we need to verify against the same library base as the build.

ann0see · 2021-02-18T21:16:28Z

Ok. Will merge this now.

ann0see · 2021-02-18T21:17:10Z

There are still some todo items, but I think it's ready. Next big step:

Start the release process!

ann0see and others added 7 commits February 6, 2021 22:04

Add compilation support for nsProcess

7fc6bb5

Fixes jamulussoftware#859

Use older version of Qt

b22fc95

This will support macOS < 10.13. Fixes jamulussoftware#959

unified autobuild github-action

e4a12d1

stub for windows build docker

3732f00

Use Qt5.9.9 to compile on macOS

addc12f

Apply styling changes

492d681

Add a line break

a933b7a

nefarius2001 mentioned this pull request Feb 10, 2021

Use older version of Qt #964

Merged

Add NSIS COPYING file

46ad3e0

See original source: https://sourceforge.net/p/nsis/code/HEAD/tree/NSIS/trunk/COPYING

ann0see linked an issue Feb 11, 2021 that may be closed by this pull request

Qt 5.15 breaks macOS < 10.13 support #959

Closed

ann0see added this to the Release 3.7.0 milestone Feb 12, 2021

nefarius2001 mentioned this pull request Feb 12, 2021

submodule checkout broken #984

Closed

nefarius2001 added 3 commits February 12, 2021 22:17

Merge remote-tracking branch 'x_github_ann0see/nsProcessCompile' into…

81ebb78

… autobuild_head

Merge remote-tracking branch 'x_github_ann0see/UseOlderQt' into autob…

3eb2f20

…uild_head

autobuild improved (single github-action, harmonized autobuild)

a0a2f12

- consistently in three steps: prepare-build-copy - artifacts stored for limited amout of days with the github-action-run - files named by githash/release - auto-creation of releases

nefarius2001 mentioned this pull request Feb 13, 2021

Github Workflow CodeQL: Check out submodules #986

Closed

nefarius2001 force-pushed the autobuild/stable2 branch from e4a12d1 to a0a2f12 Compare February 13, 2021 01:26

nefarius2001 marked this pull request as ready for review February 13, 2021 01:26

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'x_github_corrados/master' into autobuil…

efdf5e6

…d/stable2

ann0see requested changes Feb 13, 2021

View reviewed changes

Merge remote-tracking branch 'upst/master' into autobuild/stable2

89f68fb

ann0see requested changes Feb 18, 2021

View reviewed changes

ann0see added 2 commits February 18, 2021 17:17

Add quotes

638f63a

Remove flatpak prepare script

edf66a6

ann0see force-pushed the autobuild/stable2 branch 2 times, most recently from 835f304 to edf66a6 Compare February 18, 2021 16:37

Make files executable

408b985

ann0see self-requested a review February 18, 2021 16:58

ann0see approved these changes Feb 18, 2021

View reviewed changes

autobuild/android/autobuild_apk_1_prepare.sh Show resolved Hide resolved

ann0see requested a review from pljones February 18, 2021 17:18

pljones reviewed Feb 18, 2021

View reviewed changes

autobuild/ensure_THIS_JAMULUS_PROJECT_PATH.sh Outdated Show resolved Hide resolved

pljones reviewed Feb 18, 2021

View reviewed changes

autobuild/linux/autobuild_deb_1_prepare.sh Outdated Show resolved Hide resolved

pljones reviewed Feb 18, 2021

View reviewed changes

autobuild/mac/artifacts/autobuild_mac_1_prepare.sh Outdated Show resolved Hide resolved

pljones reviewed Feb 18, 2021

View reviewed changes

autobuild/mac/codeQL/autobuild_mac_3_copy_files.sh Outdated Show resolved Hide resolved

pljones approved these changes Feb 18, 2021

View reviewed changes

rework

b2ac9e5

ann0see approved these changes Feb 18, 2021

View reviewed changes

ann0see merged commit 887ed6b into jamulussoftware:master Feb 18, 2021

hoffie mentioned this pull request Feb 20, 2021

Automated github builds #854

Closed

This was referenced Mar 9, 2022

Autobuild: Clean up workflow description #2470

Merged

Android: Use aqt #2479

Closed

Autobuild: Reorganize macOS/iOS build scripts #2476

Merged



		echo "Building... qmake"
		if [-x /Users/runner/work/jamulus/jamulus/Qt/5.15.2/clang_64/bin/qmake]

Comments

Conversation

nefarius2001 commented Feb 10, 2021

Uh oh!

ann0see commented Feb 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nefarius2001 commented Feb 10, 2021

Uh oh!

nefarius2001 commented Feb 11, 2021

Uh oh!

nefarius2001 commented Feb 13, 2021

Uh oh!

pljones commented Feb 13, 2021

Uh oh!

nefarius2001 commented Feb 13, 2021

Uh oh!

pljones commented Feb 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoffie commented Feb 13, 2021

Uh oh!

This comment has been minimized.

nefarius2001 commented Feb 13, 2021

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ann0see Feb 13, 2021

Choose a reason for hiding this comment

Uh oh!

nefarius2001 Feb 13, 2021

Choose a reason for hiding this comment

Uh oh!

ann0see Feb 14, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ann0see Feb 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pljones Feb 18, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ann0see left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pljones Feb 18, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pljones commented Feb 18, 2021

Uh oh!

pljones commented Feb 18, 2021

Uh oh!

ann0see commented Feb 10, 2021 •

edited

Loading

pljones commented Feb 13, 2021 •

edited

Loading

ann0see Feb 18, 2021 •

edited

Loading

ann0see left a comment •

edited

Loading