Add compilation support for nsProcess#962
Conversation
|
@nefarius2001 |
|
Probably we could merge this, but it's already included nefarius PR. |
|
Unfortunately, I can't approve it myself. |
|
I don't know enough about this module to comment knowledgeably. I assume the CI compiles it ok, and that it has been tested out on a Windows machine. Happy to approve if so. |
|
Yes. It compiles on Windows and also on GH Actions. I'm not responsible for all the deprecation warnings from this code. If we have time, we might fix them (but the code is not much Jamulus related) |
Ah - @nefarius2001 can this be closed then? |
|
Sort of - I'd suggest closing when #978 is merged |
Fixes #859