Skip to content

Comments

Add compilation support for nsProcess#962

Merged
ann0see merged 4 commits intojamulussoftware:masterfrom
ann0see:nsProcessCompile
Feb 18, 2021
Merged

Add compilation support for nsProcess#962
ann0see merged 4 commits intojamulussoftware:masterfrom
ann0see:nsProcessCompile

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Feb 6, 2021

Fixes #859

@ann0see ann0see requested a review from a team February 7, 2021 14:59
@ann0see ann0see requested a review from pljones February 11, 2021 08:29
@ann0see
Copy link
Member Author

ann0see commented Feb 11, 2021

@nefarius2001 I assume, you'll need to include this PR in your PR too. I've now looked at your PR and I think this doesn't include this PR, so I think, this is ready?

@ann0see ann0see requested a review from a team February 12, 2021 12:19
@ann0see ann0see added this to the Release 3.7.0 milestone Feb 12, 2021
@pljones
Copy link
Collaborator

pljones commented Feb 17, 2021

@softins any comments on this one? Else @ann0see, do you want to approve and merge for 3.7.0?

@ann0see
Copy link
Member Author

ann0see commented Feb 17, 2021

Probably we could merge this, but it's already included nefarius PR.

@ann0see
Copy link
Member Author

ann0see commented Feb 17, 2021

Unfortunately, I can't approve it myself.

@softins
Copy link
Member

softins commented Feb 17, 2021

I don't know enough about this module to comment knowledgeably. I assume the CI compiles it ok, and that it has been tested out on a Windows machine. Happy to approve if so.

@ann0see
Copy link
Member Author

ann0see commented Feb 17, 2021

Yes. It compiles on Windows and also on GH Actions. I'm not responsible for all the deprecation warnings from this code. If we have time, we might fix them (but the code is not much Jamulus related)

@pljones
Copy link
Collaborator

pljones commented Feb 17, 2021

Probably we could merge this, but it's already included nefarius PR.

Ah - @nefarius2001 can this be closed then?

@nefarius2001
Copy link
Contributor

Sort of - I'd suggest closing when #978 is merged

@ann0see ann0see merged commit 81ebb78 into jamulussoftware:master Feb 18, 2021
@ann0see ann0see deleted the nsProcessCompile branch February 18, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

About hosting nsProcess.dll binary

4 participants