Skip to content

Comments

Move installer translation scripts to /src/res/translation/wininstaller#953

Merged
ann0see merged 5 commits intojamulussoftware:masterfrom
ann0see:WinInstaller
Feb 9, 2021
Merged

Move installer translation scripts to /src/res/translation/wininstaller#953
ann0see merged 5 commits intojamulussoftware:masterfrom
ann0see:WinInstaller

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Feb 4, 2021

Fixes #944

Includes #938

@ann0see ann0see self-assigned this Feb 5, 2021
@ann0see ann0see requested a review from jerogee February 6, 2021 22:50
@ann0see
Copy link
Member Author

ann0see commented Feb 6, 2021

To Jerogee: this PR includes your changes too. I think if you approve it (and another maindeveloper does too) we can merge this.

jerogee
jerogee approved these changes Feb 7, 2021
View reviewed changes
Copy link
Contributor

@jerogee jerogee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I could only not test whether the new relative paths resolve correctly, but in principle they should.

@ann0see ann0see requested a review from a team February 7, 2021 14:56
@ann0see
Copy link
Member Author

ann0see commented Feb 7, 2021

Sorry @pljones for removing the review. Wanted to test something: I assigned a team and would like to know what/who receives a message.

@pljones
Copy link
Collaborator

pljones commented Feb 7, 2021

Looks like my review stayed.

@softins
Copy link
Member

softins commented Feb 7, 2021 •
edited
Loading

I received review request emails for all the requests to maindevelopers. The question now is whether a review from one, or two, of the team leaves the request pending for maindevelopers. I’ll do some reviewing tomorrow, and we’ll see.

@jerogee
Copy link
Contributor

jerogee commented Feb 7, 2021

@ann0see , I only got a "review requested" label added to the issue notification that was already there because I was mentioned/active. Not part of maindevelopers, so my approval does not count for the needed 2 approving reviews:
image

@softins , like to help out and tick this one off? ;-)

softins
softins reviewed Feb 7, 2021
View reviewed changes
@ann0see
Copy link
Member Author

ann0see commented Feb 8, 2021

I received review request emails for all the requests to maindevelopers.

Made a few changes to the team in the organisation and I hope now it doesn't assign the whole team.

@ann0see ann0see requested a review from softins February 8, 2021 20:39
@ann0see ann0see merged commit 388cd95 into jamulussoftware:master Feb 9, 2021
@ann0see ann0see deleted the WinInstaller branch February 9, 2021 08:25
@pljones pljones added this to the Release 3.7.0 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pljones pljones pljones approved these changes

@softins softins softins approved these changes

+1 more reviewer

@jerogee jerogee jerogee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ann0see ann0see

Labels

None yet

Projects

Tracking
Status: Triage

Milestone

Release 3.7.0

Development

Successfully merging this pull request may close these issues.

Move installer translation scripts to /src/res/translation/wininstaller

4 participants

@ann0see @pljones @softins @jerogee