Skip to content

Comments

Add feature request template#941

Merged
ann0see merged 2 commits intomasterfrom
featureRequestTemplate
Feb 10, 2021
Merged

Add feature request template#941
ann0see merged 2 commits intomasterfrom
featureRequestTemplate

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Feb 2, 2021

Same as #924

@ann0see ann0see requested review from gilgongo and pljones February 6, 2021 22:44
@pljones
Copy link
Collaborator

pljones commented Feb 7, 2021

Hm.

I think the template should have a guidance section (with "remove this before submitting", of course) that explains what is likely to be considered, let alone accepted.

That is - Jamulus does what Jamulus does. It avoids doing what other software does deliberately to avoid both processing overhead and maintenance overhead. So if there is another way to solve the problem, that's likely a better solution.

@ann0see
Copy link
Member Author

ann0see commented Feb 7, 2021

What about:

"Thanks for opening a new feature request! Please keep in mind that Jamulus achieves low latency audio by reducing complexity and following the "Keep it simple and stupid" approach. Adding new features may result in more processing and maintenance overhead so please be sure that your feature can not be achieved by different approaches/software too."

@pljones
Copy link
Collaborator

pljones commented Feb 7, 2021

Yep, that's the idea. Maybe add "Make it clear why here." on the end.

@ann0see
Copy link
Member Author

ann0see commented Feb 8, 2021

I wouldn't stress it too much since it might sound intimidating.

If we go too far it could sound like:

Thanks for your feature request and all the work you put into thinking about it. Since we don't like to introduce too many new features, you can be quite sure that it will not be implemented.

@ann0see
Copy link
Member Author

ann0see commented Feb 10, 2021

I've now added your suggestion, but my comment is stil valid ;-).

@pljones
Copy link
Collaborator

pljones commented Feb 10, 2021

Looks better now :)

@ann0see ann0see merged commit fd81241 into master Feb 10, 2021
@ann0see ann0see deleted the featureRequestTemplate branch February 10, 2021 19:39
@ann0see
Copy link
Member Author

ann0see commented Feb 10, 2021

Great! merged now.

@pljones pljones added this to the Release 3.7.0 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

3 participants