Skip to content

Comments

Add Dutch translation for Windows installer.#938

Closed
jerogee wants to merge 4 commits intojamulussoftware:masterfrom
jerogee:add/dutch-translation-installer
Closed

Add Dutch translation for Windows installer.#938
jerogee wants to merge 4 commits intojamulussoftware:masterfrom
jerogee:add/dutch-translation-installer

Conversation

@jerogee
Copy link
Contributor

@jerogee jerogee commented Feb 1, 2021

No description provided.

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks. Just a few comments (especially the two dots might just be a typo)

Note to self: this hints me at the question: Should we move this folder to src/res/?

@ann0see ann0see self-requested a review February 2, 2021 14:54
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the two dots, this is ready.

@ann0see ann0see requested a review from gilgongo February 3, 2021 14:43
ann0see added a commit that referenced this pull request Feb 4, 2021
@ann0see ann0see mentioned this pull request Feb 4, 2021
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Ready to be merged, I think?

@ann0see ann0see self-assigned this Feb 4, 2021
@ann0see
Copy link
Member

ann0see commented Feb 4, 2021

@jerogee would it be ok if I include your work in a pr which includes this: #944

@jerogee
Copy link
Contributor Author

jerogee commented Feb 4, 2021

@ann0see: sure, go ahead!

@ann0see
Copy link
Member

ann0see commented Feb 4, 2021

Great. I will close this PR then and add it to another one (including the changes of #949 )

@ann0see ann0see closed this Feb 4, 2021
ann0see added a commit to ann0see/jamulus that referenced this pull request Feb 4, 2021
ann0see added a commit to ann0see/jamulus that referenced this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants