Move submodules to relative paths#934
Merged
pljones merged 1 commit intojamulussoftware:masterfrom Feb 10, 2021
Merged
Conversation
hoffie
reviewed
Feb 1, 2021
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Not sure if relevant, but this could make it a bit harder to use for anonymous Github users (i.e. Jamulus repo cloned via http):
Before this PR:
$ git clone https://github.com/jamulussoftware/jamulus.git && cd jamulus
[...]
$ git submodule init && git submodule update
Submodule 'libs/oboe' (https://github.com/google/oboe.git) registered for path 'libs/oboe'
[...]
Cloning into '/tmp/jamulus/libs/oboe'...
[...]
Submodule path 'libs/oboe': checked out '6c6bff4c5a67b5da3067dc8b1480c2e310d81a2e'
[...]
After this PR:
$ git clone https://github.com/jamulussoftware/jamulus.git && cd jamulus
[...]
$ git fetch origin refs/pull/934/head:pr934 && git checkout pr934
[...]
Switched to branch 'pr934'
$ git submodule init && git submodule update
Submodule 'libs/oboe' ([email protected]:google/oboe.git) registered for path 'libs/oboe'
[...]
Cloning into '/tmp/jamulus/libs/oboe'...
Enter passphrase for key '...: # would break if I hadn't set up ssh for github.com
Someone StackOverflow suggests using relative paths (which seem to be considered relative to origin, not the file system) and this seems to work in a quick test.
Collaborator
Author
|
Github are removing https clone access "soon". I expect it's so they can ensure they collect everyone's email address - i.e. you have to register to download source. |
pljones
force-pushed
the
feature/move-submodules-to-ssh
branch
from
16dbe7d to
2d2391e
Compare
pljones
changed the title
Collaborator
Author
|
OK, had time to check this out and moved to relative paths as suggested. Thanks! |
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Feb 12, 2021
The relative paths in .gitmodules contained a stray github.com/ path component which broke submodule resolution. Got broken in jamulussoftware#934 Fixes jamulussoftware#984 Signed-off-by: Christian Hoffmann <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.