Skip to content

Comments

Add bug report template#924

Merged
gilgongo merged 5 commits intomasterfrom
addBugTemplate
Feb 2, 2021
Merged

Add bug report template#924
gilgongo merged 5 commits intomasterfrom
addBugTemplate

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Jan 29, 2021

Adding a bug template also makes it possible to automatically set the bug label.

@ann0see
Copy link
Member Author

ann0see commented Jan 30, 2021

It happened as I thought/feared: aefb1b4

Wanted to propose a feature request template and I committed to the master branch. Sorry (it's already reverted). Nevertheless: Can somebody have a look at this commit too and give feedback?

@ann0see ann0see added the feature request Feature request label Jan 30, 2021
@corrados
Copy link
Contributor

I guess this will be the first time you (the main developer team) have to deal with the decision of the merge on your own. I already removed me from the jamulussoftware project, so, I actually do not have the rights anymore to perform the merge.

@hoffie
Copy link
Member

hoffie commented Jan 31, 2021

Can somebody have a look at this commit too and give feedback?

Not sure if you are seeking feedback from other maintainers only. I'm taking the freedom to add a note:

In my Github experience, people sometimes forget to remove the boilerplate text. My suggestion would therefore be to place the instructions in a comment so that they can still be seen when opening the issue but will not be part of the issue in the end.

Example: https://raw.githubusercontent.com/prometheus/prometheus/master/.github/ISSUE_TEMPLATE/bug_report.md

Having a basic structure sounds good. I also like the proposed headers.

@pljones
Copy link
Collaborator

pljones commented Jan 31, 2021

I'd agree with @hoffie's suggestions -- make it clear the headings aren't headings but information to be substituted.

@hoffie
Copy link
Member

hoffie commented Jan 31, 2021

I'd agree with @hoffie's suggestions -- make it clear the headings aren't headings but information to be substituted.

Actually, I would keep the headings but only comment out the descriptions.

ann0see and others added 4 commits February 1, 2021 16:28
@ann0see
Copy link
Member Author

ann0see commented Feb 1, 2021

I think this looks good now. Thanks @hoffie!

@ann0see
Copy link
Member Author

ann0see commented Feb 2, 2021

@gilgongo can you approve and merge this if everything is ok?

@gilgongo
Copy link
Member

gilgongo commented Feb 2, 2021

OK sure.

@gilgongo gilgongo merged commit 46a96eb into master Feb 2, 2021
@gilgongo gilgongo deleted the addBugTemplate branch February 2, 2021 17:42
@pljones pljones added this to the Release 3.7.0 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request Feature request

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

5 participants