Skip to content

Comments

Retire manual.md#780

Merged
corrados merged 4 commits intojamulussoftware:masterfrom
gilgongo:master
Dec 14, 2020
Merged

Retire manual.md#780
corrados merged 4 commits intojamulussoftware:masterfrom
gilgongo:master

Conversation

@gilgongo
Copy link
Member

See #779

Replace link to manual.
Replace with link to manual on jamulus.io
Replace with link to manual in jamulus.io
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other review

#define CLIENT_GETTING_STARTED_URL "https://jamulus.io/wiki/Getting-Started"
#define SERVER_GETTING_STARTED_URL "https://jamulus.io/wiki/Running-a-Server"
#define SOFTWARE_MANUAL_URL "https://github.com/corrados/jamulus/blob/master/src/res/homepage/manual.md"
#define SOFTWARE_MANUAL_URL "https://jamulus.io/wiki/Software-Manual"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my POV this should be translatable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should automatically link to the language which is set in Jamulus.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok. Is that something we can do on this PR then?

Copy link
Collaborator

@pljones pljones Dec 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that been done by the Wiki itself? (That being, in part, why the move is being made.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I'd have no idea how to automate that.

Copy link
Member

@ann0see ann0see Dec 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even suggest to automate it. We could maybe make the message a bit more prominent.

But I think, this link should be part of the normal translation files. @corrados would this be possible? Can we put the link in the translation files?

Copy link
Collaborator

@pljones pljones Dec 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should happen if there's a translation set for Jamulus but not for that language on the wiki? Just use the default pages (i.e. same as for any string not translated)?

I'm pretty sure the path could appear in the translation strings and have a translate("wiki", url) wrapper where used to get the translated value, given the appropriate translation string support.

Copy link
Member

@ann0see ann0see Dec 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should happen if there's a translation set for Jamulus but not for that language on the wiki? Just use the default pages (i.e. same as for any string not translated)?

Yes. I agree.

I'm pretty sure the path could appear in the translation strings

Should I'd put the normal English link as parameter to tr() and only translate the languages which are translated in the wiki. The same should happen for getting started,...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string should be translatable, then Jamulus GUI translators can do their job when translating their po files.

El retardo total se calcula con el ping y el retardo ocasionado por la configuración de buffers.

La Tasa de Subida de Audio depende del tamaño actual de los paquetes de audio y la configuración de compresión de audio. Asegúrate de que la tasa de subida no es mayor que la velocidad de subida disponible (comprueba la tasa de subida de tu conexión a internet, por ejemplo con [speedtest.net](http://speedtest.net)).
## Movido a https://jamulus.io/wiki/Software-Manual
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I think I've done that (not sure).

Link to Spanish version
@corrados corrados merged commit 0ef7b2d into jamulussoftware:master Dec 14, 2020
@ann0see ann0see mentioned this pull request Dec 14, 2020
@pljones pljones added this to the Release 3.7.0 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

5 participants