Add missing #include <QVersionNumber> in classes that use it#686
Merged
corrados merged 1 commit intojamulussoftware:masterfrom Oct 22, 2020
Merged
Add missing #include <QVersionNumber> in classes that use it#686corrados merged 1 commit intojamulussoftware:masterfrom
corrados merged 1 commit intojamulussoftware:masterfrom
Conversation
It's already included in clientdlg.h. This fixes building with Qt 5.7 -- it's OK with Qt 5.13 (presumably because one of the other headers transitively includes QVersionNumber).
Contributor
|
Can you please take a look at this: https://travis-ci.org/github/corrados/jamulus/jobs/738215226 |
Contributor
Author
|
That build machine is on Ubuntu Xenial, which has Qt 5.5; QVersionNumber was introduced in Qt 5.6. I'll make another pull request to add some version guards... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's already included in
clientdlg.h.This fixes building with Qt 5.7 on Debian stable -- it's OK with Qt 5.13 (presumably because one of the other headers transitively includes
QVersionNumber).