Initial working Android Code#661
Merged
corrados merged 2 commits intojamulussoftware:masterfrom Oct 5, 2020
Merged
Conversation
Closed
Contributor
|
Thanks. I'll merge it now and try it out on my Android phone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains code changes to the already existing android code solving some of the issues. It is linked to Issue #83.
It has been minimally tested on a Google Pixel 3a but I could listen to other participants and they could hear me.
Key things are:
iNewPrefMonoBufferSizeinCSound::Init()I guess there's still a lot of work to do in the handling of error cases and possible variations in the oboe behaviour across different devices, but I hope this could be a starting point.
Please comment.