update d/rules (workaround issue in desktop file)#563
Merged
corrados merged 1 commit intojamulussoftware:masterfrom Sep 1, 2020
trebmuh:patch-1
Merged
update d/rules (workaround issue in desktop file)#563corrados merged 1 commit intojamulussoftware:masterfrom trebmuh:patch-1
corrados merged 1 commit intojamulussoftware:masterfrom
trebmuh:patch-1
Conversation
Contributor
Yes, good idea. |
Contributor
|
Thanks! I hadn't noticed that the desktop file was autogenerated and didn't check it. This probably explains some Lintian warnings, I thought it was only confused... A desktop file for jamulus-headless is IMO pointless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
execfield is replaced with jamulus-headless which isn't what's expected by the user to be executed.Pinging @tormodvolden since you've been working on the debian/ files recently.
@corrados : maybe it could be a good idea to generate a desktop file for jamulus-GUI ("jamulus.desktop") and another desktop file for jamulus-headless ("jamulus-headless.desktop").