Skip to content

Comments

Accessible Server List#3606

Merged
ann0see merged 5 commits intojamulussoftware:mainfrom
chigkim:accessible-server-list
Jan 26, 2026
Merged

Accessible Server List#3606
ann0see merged 5 commits intojamulussoftware:mainfrom
chigkim:accessible-server-list

Conversation

@chigkim
Copy link
Contributor

@chigkim chigkim commented Jan 25, 2026 •
edited
Loading

Make the server list accessible by making the screen reader to announce relevant information when a server or a client is selected.

  • Open connect dialog
  • Press tab to focus on the table.
  • Press up/down arrow to select server. If you have a screen reader on, it'll announce all the information.
  • Press right/left arrow to expand/collapse.
    • If you select a client, it'll also announce instrument and country.

@pljones @ann0see

@chigkim chigkim force-pushed the accessible-server-list branch 2 times, most recently from c7be8f1 to 3b74fe8 Compare January 25, 2026 14:46
@chigkim
Copy link
Contributor Author

chigkim commented Jan 25, 2026

I ran

clang-format -i src/connectdlg.cpp
clang-format -i src/connectdlg.h

However, the coding Style Check keeps failing.
It also changed couple of things that was not part of my change.

@pljones @ann0see, could you please review and help?

Thanks!

@ann0see ann0see added the macOS macOS runtime issue label Jan 25, 2026
@ann0see ann0see added this to the Release 3.12.0 milestone Jan 25, 2026
@ann0see ann0see added this to Tracking Jan 25, 2026
@github-project-automation github-project-automation bot moved this to Triage in Tracking Jan 25, 2026
@ann0see ann0see moved this from Triage to Waiting on Team in Tracking Jan 25, 2026
ann0see
ann0see requested changes Jan 25, 2026
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll check it out once I have access to macOS

@github-project-automation github-project-automation bot moved this from Waiting on Team to Waiting externally in Tracking Jan 25, 2026
@ann0see ann0see self-requested a review January 25, 2026 15:06
ann0see
ann0see reviewed Jan 25, 2026
View reviewed changes
@chigkim
Copy link
Contributor Author

chigkim commented Jan 25, 2026

I haven't tested on Windows, but it should work both Windows and MacOS.

@chigkim chigkim force-pushed the accessible-server-list branch from 3b74fe8 to f902bc2 Compare January 25, 2026 15:36
@ann0see ann0see changed the title Accessible Server Lis Accessible Server List Jan 25, 2026
@ann0see ann0see mentioned this pull request Jan 25, 2026
Closed
5 tasks
ann0see
ann0see reviewed Jan 25, 2026
View reviewed changes
@chigkim
Copy link
Contributor Author

chigkim commented Jan 25, 2026 •
edited
Loading

@ann0see Could you confirm if it reports the information in the right order and the correct number of musicians?
Thanks!

ann0see
ann0see reviewed Jan 25, 2026
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think now it works as expected. If a new user connects, the server name is correctly announced and a number is up to date. Also the order is now correct.

ann0see
ann0see reviewed Jan 25, 2026
View reviewed changes
ann0see
ann0see reviewed Jan 25, 2026
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I've tested it on Windows, I'll report back. Otherwise, I think it's fine. Thank you very much! It's by far the cleanest approach.

@ann0see ann0see requested a review from pljones January 25, 2026 21:51
@ann0see ann0see moved this from Waiting externally to Waiting on Team in Tracking Jan 25, 2026
@ann0see ann0see mentioned this pull request Jan 25, 2026
Open
65 tasks
@chigkim
Copy link
Contributor Author

chigkim commented Jan 26, 2026 •
edited
Loading

Once this is merged, I'm going to kill my old build because all my accessibility fixes are merged.
Assuming it works on Windows, do you guys need anything else from me to get this merged?
Thanks!

@chigkim chigkim requested a review from ann0see January 26, 2026 04:09
pljones
pljones reviewed Jan 26, 2026
View reviewed changes
@pljones pljones linked an issue Jan 26, 2026 that may be closed by this pull request
Server List Is Not Accessible With Screen Reader on Mac #490
Closed
@ann0see ann0see merged commit dfb671a into jamulussoftware:main Jan 26, 2026
11 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Team to Done in Tracking Jan 26, 2026
@ann0see
Copy link
Member

ann0see commented Jan 26, 2026

(Windows woks with the native tree view)

@chigkim chigkim deleted the accessible-server-list branch January 26, 2026 19:37
@pljones
Copy link
Collaborator

pljones commented Jan 30, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pljones pljones pljones approved these changes

@ann0see ann0see ann0see approved these changes

Assignees

@ann0see ann0see

@chigkim chigkim

Labels

macOS macOS runtime issue

Projects

Tracking
Status: Done

Milestone

Release 3.12.0

Development

Successfully merging this pull request may close these issues.

Server List Is Not Accessible With Screen Reader on Mac

3 participants

@chigkim @ann0see @pljones