Merged
Conversation
Member
Author
|
pljones
reviewed
Dec 28, 2025
src/util.h
Outdated
| void OnHelpClientGetStarted() { QDesktopServices::openUrl ( QUrl ( CLIENT_GETTING_STARTED_URL ) ); } | ||
| void OnHelpServerGetStarted() { QDesktopServices::openUrl ( QUrl ( SERVER_GETTING_STARTED_URL ) ); } | ||
| void OnHelpSoftwareMan() { QDesktopServices::openUrl ( QUrl ( SOFTWARE_MANUAL_URL ) ); } | ||
| void OnHelpPrivacyPolicy() { QDesktopServices::openUrl ( QUrl ( PRIVACY_POLICY_URL ) ); } |
Collaborator
There was a problem hiding this comment.
Is it going to be okay for the privacy policy to go to an unidentified website (in terms of the not yet having read the privacy policy that would cover the website, too...), rather than displaying the text locally (like OnHelpAbout and OnHelpAboutQt)?
(Also, can we have these in the same order as the menu whilst you're here.)
Member
Author
There was a problem hiding this comment.
I believe it's ok to link outside of the app.
ann0see
force-pushed
the
iOS/addPrivPol
branch
from
d18bee3 to
26f8a55
Compare
pljones
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Adds a link to the privacy policy
CHANGELOG: Add link to privacy policy
Context: Fixes an issue?
Fixes: #3584
Does this change need documentation? What needs to be documented and how?
No. But translation.
Status of this Pull Request
Review
What is missing until this pull request can be merged?
Review
Checklist