Avoid sleeping on windows if connected#3498
Conversation
|
Depends on #3499 to run the CI |
|
Linux might be the next step (in another PR). |
softins
left a comment
softins
left a comment
There was a problem hiding this comment.
I haven't tested it myself, but the changes look sensible, and appear to comply with the Win32 API docs.
On a related note, I have noticed for a long time that Jamulus on my Mac prevents display dimming or sleeping all the time it is running, and I have thought that it would be better if it did so only while connected, similar to this PR. Maybe another PR could change the behaviour on Mac to match that of this PR?
pljones
left a comment
pljones
left a comment
There was a problem hiding this comment.
I can't comment on the change -- but the build doesn't seem to be running properly.
ann0see
force-pushed
the
autobuild/addWindowsSleep
branch
from
261e791 to
881b416
Compare
|
It should be fixed now |
Probably. I suppose it would be related to the objective c code we include on macOS builds |
3 participants
Short description of changes
Avoids Windows to go into sleep mode if the client is connected to a server
CHANGELOG: Windows: Avoid screensaver or sleeping if connected to a server
Context: Fixes an issue?
Related to: #834
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review. A pre-build was tested on Win 11 and it worked as expected: If a connection to the server stands, the device does not sleep. Once it is disconnected, it will sleep.
What is missing until this pull request can be merged?
Testing on another system.
Checklist