Apply rate limiting to Pan as well as Gain#3429
Merged
softins merged 2 commits intojamulussoftware:mainfrom Dec 6, 2024
Merged
Apply rate limiting to Pan as well as Gain#3429softins merged 2 commits intojamulussoftware:mainfrom
softins merged 2 commits intojamulussoftware:mainfrom
Conversation
softins
force-pushed
the
rate-limit-pan
branch
from
1fd04ad to
8f7b625
Compare
softins
force-pushed
the
rate-limit-pan
branch
from
8f7b625 to
3d2f6c3
Compare
ann0see
approved these changes
Dec 5, 2024
pljones
reviewed
Dec 6, 2024
pljones
reviewed
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
This PR applies the same rate-limiting to Pan change message as is currently done for Gain change messages since #2535
CHANGELOG: Client: Apply rate-limiting to Pan change messages to eliminate lag in their effect.
Context: Fixes an issue?
Fixes #3428
Does this change need documentation? What needs to be documented and how?
No, it's just a performance improvement.
Status of this Pull Request
Tested and ready for review
What is missing until this pull request can be merged?
Nothing
Checklist