Add "Sort by Channel" to mixer view#3418
Conversation
pljones
force-pushed
the
sort-faders-by-channel
branch
from
7400201 to
5bda36c
Compare
pljones
force-pushed
the
sort-faders-by-channel
branch
2 times, most recently
from
9b91d75 to
7f56cb7
Compare
pljones
force-pushed
the
sort-faders-by-channel
branch
from
7f56cb7 to
9e569fa
Compare
pljones
force-pushed
the
sort-faders-by-channel
branch
from
9e569fa to
9cc1d32
Compare
pljones
force-pushed
the
sort-faders-by-channel
branch
from
9cc1d32 to
01944f9
Compare
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
I'll test it on my device soon.
| @@ -558,11 +558,12 @@ enum ERecorderState | |||
| enum EChSortType | |||
There was a problem hiding this comment.
Not part of this PR, but having this enum in utils looks unorganized.
There was a problem hiding this comment.
Yeah. I'll look to move it.
There was a problem hiding this comment.
OK it's in util.h because it's used in CSettings as well as the mixer board, I think -- all of the static_cast<ENUM> enums that CSettings does get shared with somewhere else and CSettings doesn't want to be fishing through lots of headers, so they get dumped into util.h.
(Ideally, CSettings wouldn't work like that: each component would have its own settings and read or write them to the XML that CSettings simply read from a file or wrote to a file... But that is definitely a different PR!)
|
Should still have a quick look by @softins, but otherwise I think it's good to be merged. |
ann0see
added
the
needs documentation
Will look soon! |
softins
left a comment
softins
left a comment
There was a problem hiding this comment.
Looks good to me - nice code!
Tested on a Pi with Qt 5.15.8
|
jamulussoftware/jamuluswebsite#1059 raised to get the documentation change done. |
pljones
removed
the
needs documentation
4 participants
Short description of changes
Adds "Sort by Channel" to mixer view
CHANGELOG: Client: Add "Sort by Channel" to mixer view
Context: Fixes an issue?
Fixes #3417
Does this change need documentation? What needs to be documented and how?
Yes. The new option needs documenting. The entry should explain its relevance to
--ctrlmidich.Status of this Pull Request
Test working on Ubuntu, Qt 6.8.0
What is missing until this pull request can be merged?
Review, testing on other platforms.
Checklist