Merged
Conversation
Member
|
Thanks. Did you report the compiler warnings to upstream too? |
Member
Author
Not yet, I wanted to see if they had been fixed in any branches first. But I intend to. |
Member
Author
ann0see
requested changes
Oct 14, 2024
Member
|
Otherwise, works on Debian 12 (client) |
ann0see
approved these changes
Oct 16, 2024
softins
requested review from
ann0see and
pljones
and removed request for
ann0see
Member
Collaborator
|
Jack on Windows has decided it's going to crash for me at the moment (it goes through phases). No audio on my Linux box (and, as Jack on Windows crashes, I can't use Jack Net to send the audio over to Windows, either). Audio out on Windows is okay. I'll install on my jamming box tomorrow but I'd go with it for now. |
pljones
approved these changes
Nov 1, 2024
Collaborator
pljones
left a comment
pljones
left a comment
There was a problem hiding this comment.
Didn't crash (JACK and ASIO on Windows). ASIO audio out was fine.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Update Opus library to the latest 1.5.2 release, plus a couple of fixes.
CHANGELOG: Dependencies: Update Opus library to v1.5.2
Context: Fixes an issue?
Existing Jamulus is using V1.4 of Opus. There are improvements to V1.5.2, which may enhance audio quality in some situations. It's just good to be on a current version. This was based on the distribution tarball for V1.5.2, not on a gitlab checkout, which would require an extra configuration step before use.
A couple of extra fixes were added, one a backport of a fix for a segfault, and two to silence compiler warnings.
Does this change need documentation? What needs to be documented and how?
Probably not, as it's just internal.
Status of this Pull Request
Ready for review. Tested on Linux server and Mac client. Hard to tell if the audio is slightly improved, but it's certainly not worse.
What is missing until this pull request can be merged?
Review. Testing on other platforms.
Checklist