Add changable bundle id and docs for macOS signing#3348
Closed
ann0see wants to merge 2 commits intojamulussoftware:mainfrom
Closed
Add changable bundle id and docs for macOS signing#3348ann0see wants to merge 2 commits intojamulussoftware:mainfrom
ann0see wants to merge 2 commits intojamulussoftware:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ann0see
force-pushed
the
mac/AddBundleVarAndDoc
branch
from
ea4bad4 to
26bd38e
Compare
ann0see
force-pushed
the
mac/AddBundleVarAndDoc
branch
from
26bd38e to
f336bf3
Compare
ann0see
force-pushed
the
mac/AddBundleVarAndDoc
branch
from
f336bf3 to
be8f12c
Compare
ann0see
commented
Aug 19, 2024
ann0see
force-pushed
the
mac/AddBundleVarAndDoc
branch
from
81b3e5c to
be8f12c
Compare
Collaborator
|
Will this be in for 3.11.0 release? If so we should put it on the tracking board as in progress for the release. As it affects the release process, I feel we should try to target a release... |
Member
Author
|
Yes. Agree |
Member
Author
|
Maybe this will be replaced by another PR soon. I'm refactoring the build script for macOS now. |
softins
approved these changes
Aug 22, 2024
Member
softins
left a comment
softins
left a comment
There was a problem hiding this comment.
Changes look sensible to me. So happy to approve, even if it might get superseded.
pljones
reviewed
Aug 22, 2024
| MAC_STORE_APP_CERT: ${{ secrets.MACAPP_CERT}} | ||
| MACOS_CERTIFICATE: ${{ secrets.MACOS_CERT }} # Base64 encoded (Developer ID Application (?)) certificate. See https://help.apple.com/xcode/mac/current/#/dev154b28f09 | ||
| MACOS_CERTIFICATE_PWD: ${{ secrets.MACOS_CERT_PWD }} # Password protecting MACOS_CERTIFICATE | ||
| MACOS_CERTIFICATE_ID: ${{ secrets.MACOS_CERT_ID }} # Certificate ID of MACOS_CERTIFICATE. If unknown, import MACOS_CERT into keychain and check the ID there |
Collaborator
There was a problem hiding this comment.
Should this be more explicit?
Suggested change
| MACOS_CERTIFICATE_ID: ${{ secrets.MACOS_CERT_ID }} # Certificate ID of MACOS_CERTIFICATE. If unknown, import MACOS_CERT into keychain and check the ID there | |
| MACOS_CERTIFICATE_ID: ${{ secrets.MACOS_CERT_ID }} # Certificate ID of MACOS_CERTIFICATE. If unknown, import secrets.MACOS_CERT into keychain and check the ID there |
or have I misunderstood the reference?
This was referenced Aug 22, 2024
Member
Author
|
Ok. Superseded by: #3352 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Adds variable for a changable Bundle ID for notarization for macOS. One can add the bundle id here: https://github.com/jamulussoftware/jamulus/settings/variables/actions/new
Also adds some more (basic) documentation which needs improvement as soon as signing works, and some clean up.
CHANGELOG: Autobuild: Use variable for Bundle ID on macOS. This allows to change the bundle ID for macOS notarization on GitHub
Context: Fixes an issue?
No. Related to: #3255 (comment)
Does this change need documentation? What needs to be documented and how?
Maybe the signing - once it works.
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Review (language wise)
Checklist