Convert delete buttons to from QPushButton to QToolButton#3305
Merged
ann0see merged 1 commit intojamulussoftware:mainfrom Jul 1, 2024
Merged
Convert delete buttons to from QPushButton to QToolButton#3305ann0see merged 1 commit intojamulussoftware:mainfrom
ann0see merged 1 commit intojamulussoftware:mainfrom
Conversation
This fixes the width problem on Mac, and also makes them consistent with the delete buttons in the Server GUI Options dialog.
Member
Author
|
Connect dialog: Settings dialog: |
Collaborator
|
Added to project board and set to Waiting on team. |
pljones
approved these changes
Jul 1, 2024
ann0see
approved these changes
Jul 1, 2024
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Looks consistent on Debian. Won't have access to macOS for some time...
Member
Author
|
Thanks! |
5 tasks
pljones
added
the
needs documentation
This was referenced Jul 22, 2024
Closed
pljones
removed
the
needs documentation
Collaborator
|
jamulussoftware/jamuluswebsite#1002 raised for documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
This fixes the width problem on Mac for server in the connect dialog and custom directory in the settings dialog. It does so by making them consistent with the delete buttons in the Server GUI Options dialog, which already use
QToolButtoninstead ofQPushButton.CHANGELOG: Client: Fixed the display of delete buttons on Mac
Context: Fixes an issue?
Fixes #3241
Does this change need documentation? What needs to be documented and how?
No - bug fix only
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Testing on all platforms to verify the buttons display correctly, and are consistent with those displayed in the server dialog.
Checklist