Replace deprecated Q_OS_MACX with Q_OS_MACOS#3227
Merged
ann0see merged 1 commit intojamulussoftware:mainfrom Feb 17, 2024
Merged
Replace deprecated Q_OS_MACX with Q_OS_MACOS#3227ann0see merged 1 commit intojamulussoftware:mainfrom
ann0see merged 1 commit intojamulussoftware:mainfrom
Conversation
ann0see
reviewed
Feb 12, 2024
Member
Author
OK, I've added that to the CHANGELOG entry in the initial description. I doubt anybody is still building with a version of Qt older than 5.7.1. CentOS 7 uses 5.9.7, Ubuntu 18.04 uses 5.9.5, Debian 10 uses 5.11.3. |
pljones
approved these changes
Feb 13, 2024
ann0see
approved these changes
Feb 17, 2024
Member
|
I changed the changelog entry slightly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
This PR replaces all instances of
Q_OS_MACXwithQ_OS_MACOSCHANGELOG: Build: Replace deprecated Q_OS_MACX with Q_OS_MACOS (Jamulus now requires building with Qt >= 5.7.1)
Context: Fixes an issue?
The
#defineofQ_OS_MACOSwas introduced in Qt 5.7.1, to replaceQ_OS_MACX. The latter was still defined for backward-compatibility. Starting with Qt 6.5.2, usingQ_OS_MACXproduces a deprecation warning, for example:A similar change was made in Qt itself at https://codereview.qt-project.org/c/qt/qtbase/+/307095/2
Does this change need documentation? What needs to be documented and how?
Probably not.
Status of this Pull Request
Ready to merge,
What is missing until this pull request can be merged?
Just review
Checklist