Minor refactoring of main cpp#3191
Merged
pljones merged 3 commits intojamulussoftware:mainfrom Nov 2, 2023
Merged
Conversation
pljones
force-pushed
the
patch/minor-refactoring-of-main_cpp
branch
from
2f0d43a to
e16bd48
Compare
pljones
force-pushed
the
patch/minor-refactoring-of-main_cpp
branch
from
56def36 to
582eee0
Compare
ann0see
reviewed
Oct 25, 2023
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Main open question:
State of translation of CLI
Collaborator
Author
See #3195 |
ann0see
approved these changes
Nov 1, 2023
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Ok. Otherwise it looks good. Thanks
Collaborator
Author
|
The MacOS Legacy build has failed twice... I'll kick it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
There are four very small changes to tidy up
src/main.ccpin this pull request:This commit literally adjusts spacing for consistency.
To avoid strange handling of a
{ ... }block, I've adjusted a#ifdefposition and duplicated a line of code.At the point
bUseTranslationis used, we will only use the result in the GUI, so code adjusted to avoid duplication.We always declare and assign
pAppto something with anexec()method and we only create one instance that can be executed, so duplicate code removed for clarity.CHANGELOG: Refactor src/main.cpp
Context: Fixes an issue?
Refactoring for good code hygiene.
Does this change need documentation? What needs to be documented and how?
No change to application behaviour.
Status of this Pull Request
Can be merged.
What is missing until this pull request can be merged?
Can be merged after review.
Checklist