Update jamulus-headless.service#3187
Merged
ann0see merged 1 commit intojamulussoftware:mainfrom Oct 14, 2023
Merged
Conversation
This should be sufficient but feel free to improve if I've missed something.
mcfnord
reviewed
Oct 6, 2023
pljones
approved these changes
Oct 7, 2023
Member
|
I will test this hopefully soon on my server. |
Member
|
Thanks. |
Contributor
Author
Done. Let me know if it's missing anything, or needs rewording, thanks. |
ann0see
approved these changes
Oct 14, 2023
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Ok. Sorry for the delay. But it works fine - as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be sufficient but feel free to improve if I've missed something.
Short description of changes
The program was being executed indirectly via a call from a bash shell. This shell was also intercepting SIGUSR2 signals used to start/stop recording from the command line per #1515 (comment)
This change updates the systemd service file to execute the program directly instead of from inside a shell.
CHANGELOG: Server: Fix systemd ExecStart command line to support start/stop recording signal
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist