Autobuild: Hotfix: Remove caching and pinning of create-dmg#3149
Merged
pljones merged 2 commits intojamulussoftware:mainfrom Aug 22, 2023
Merged
Autobuild: Hotfix: Remove caching and pinning of create-dmg#3149pljones merged 2 commits intojamulussoftware:mainfrom
pljones merged 2 commits intojamulussoftware:mainfrom
Conversation
ann0see
added
bug
Member
Author
|
One of our dependencies (macOS notarization etc) just disappeared. So everything is failing. |
ann0see
force-pushed
the
hotfix/removeBrewCaching
branch
from
8061c49 to
0dc5070
Compare
Member
Author
|
Also uses alternative Xcode Staple/notarization actions. They should be verified before they get into production. Added them to the whitelist in this repo too. |
The original author deleted his repository, so using alternatives.
ann0see
force-pushed
the
hotfix/removeBrewCaching
branch
from
0dc5070 to
219bf50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Currently the brew install of create-dmg fails during the extract step of brew. This happens in deploy_mac.sh. This PR removes caching and pinning logic.
CHANGELOG: SKIP
Context: Fixes an issue?
Fixes macOS build.
Does this change need documentation? What needs to be documented and how?
Yes: Needs an issue raised that this needs fixing. Also link https://stackoverflow.com/questions/63672189/use-github-actions-cache-with-brew-install there.
Status of this Pull Request
To be tested by CI.
What is missing until this pull request can be merged?
Working CI.
Checklist