Skip to content

Comments

Build: Bump NSIS from 3.08 to 3.09 (Automated PR)#3097

Merged
pljones merged 1 commit intomainfrom
ci/bump-dependencies/NSIS
Jul 15, 2023
Merged

Build: Bump NSIS from 3.08 to 3.09 (Automated PR)#3097
pljones merged 1 commit intomainfrom
ci/bump-dependencies/NSIS

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 8, 2023

This automated Pull Request updates the used NSIS version to version 3.09.

This PR was opened by the workflow Bump dependencies (create-prs)

CHANGELOG: Build: Updated Windows Installer base (NSIS) to version 3.09

@hoffie hoffie force-pushed the ci/bump-dependencies/NSIS branch from 444d29e to 59accbc Compare July 8, 2023 08:29
@pljones
Copy link
Collaborator

pljones commented Jul 8, 2023

It would be nice if @github-actions posted a link to the change notice for the dependency update...

@ann0see ann0see self-requested a review July 9, 2023 18:47
@ann0see ann0see added this to the Release 3.10.0 milestone Jul 9, 2023
@ann0see
Copy link
Member

ann0see commented Jul 10, 2023

Posting it here: https://sourceforge.net/projects/nsis/files/NSIS%203/3.09/ as reference.

F.1 3.09
Released on July 1st, 2023

F.1.1 Changelog
F.1.1.1 Major Changes
Use isolated uninstaller directory for every instance ([bug #1296](http://sf.net/p/nsis/bugs/1296), thanks Richard Warren)
F.1.1.2 Minor Changes
Added [!assert](#5.1.9)
Fixed !uninstfinalize bug on large uninstallers ([bug #1279](http://sf.net/p/nsis/bugs/1279))
Fixed creation of missing special folders on old Windows versions where SHGetFolderPath is not available
Fixed plug-in call overwriting SetDetailsPrint lastused ([bug #1271](http://sf.net/p/nsis/bugs/1271))
Fixed !appendfile not writing to non-empty files with a BOM
Fixed LogicLib ${Switch} Unicode bug
Fixed [MakeNSISW] editor zoom level bug ([bug #1282](http://sf.net/p/nsis/bugs/1282))
F.1.1.3 Translations
Updated Brazilian Portuguese ([bug #1269](http://sf.net/p/nsis/bugs/1269))
Updated Ukrainian ([patch #308](http://sf.net/p/nsis/patches/308))
F.1.1.4 Build System
Fixed halibut compiler warnings ([patch #304](http://sf.net/p/nsis/patches/304))
Fixed various issues with very old and new GCC versions ([bug #1275](http://sf.net/p/nsis/bugs/1275), [patch #307](http://sf.net/p/nsis/patches/307), [patch #310](http://sf.net/p/nsis/patches/310))
Disable stub relocations in newer GCC ([bug #1283](http://sf.net/p/nsis/bugs/1283))

ann0see
ann0see approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install over existing install, uninstall work with the ASIO version. Also a clean install works. So I think it's good to merge.

Edit: JACK version also installs fine.

@hoffie hoffie force-pushed the ci/bump-dependencies/NSIS branch from 59accbc to 9e51119 Compare July 10, 2023 17:54
@pljones
Copy link
Collaborator

pljones commented Jul 10, 2023

Does any of that mean it's easier to convince Windows to have both ASIO and JACK installs side by side and treat them as separate? (Currently it gets confused.)

@ann0see
Copy link
Member

ann0see commented Jul 10, 2023

No. Currently you can't install JACK and ASIO.

@pljones
Copy link
Collaborator

pljones commented Jul 11, 2023

No. Currently you can't install JACK and ASIO.

You can. I do. I run them at the same time - JACK's ASIO input for one instance of Jamulus, ReaRoute to JACK to Jamulus on another JACK ASIO pair.

It's just the installer gets confused when updating or uninstalling - presumably they share a registry key.

@ann0see
Copy link
Member

ann0see commented Jul 11, 2023

Yes. They do share the same registry key and default installation directory.

@pljones pljones mentioned this pull request Jul 12, 2023
Open
@pljones
Copy link
Collaborator

pljones commented Jul 12, 2023

OK, I've opened #3103 for splitting the keys.

@hoffie hoffie force-pushed the ci/bump-dependencies/NSIS branch from 9e51119 to d74dc40 Compare July 13, 2023 21:06
@ann0see
Copy link
Member

ann0see commented Jul 15, 2023

Thanks. Do you think this PR is ready? If yes, please merge it.

@pljones pljones merged commit 2505a31 into main Jul 15, 2023
@github-actions github-actions bot deleted the ci/bump-dependencies/NSIS branch July 15, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ann0see ann0see ann0see approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Tracking
Status: Done

Milestone

Release 3.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pljones @ann0see @actions-user