Merged
Conversation
Member
Author
|
Ok. Tested and by copying the PlugIns folder to the correct folder everything works. I believe in general this PR is ready. |
Member
Author
|
@emlynmac could you please test if you can now build Jamulus on your Mac with Qt6? |
Contributor
Sorry, I'm not able - none of my machines have the QT toolchain. |
Member
Author
|
Ok. Never mind. @danryu maybe? |
pljones
reviewed
Jun 6, 2023
Found by testing and not verified to actually apply the optimizations Related to: #1841
ann0see
force-pushed
the
bugfix/1841-building-for-macos-fails
branch
from
10c7eaf to
0f512f7
Compare
pljones
approved these changes
Jun 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Fixes building on macOS via Xcode. I'm not sure if that's the correct fix - but it seems to build fine. However, the app still crashes if the PlugIn folder of a working copy isn't copied into the Jamulus.app/Contents folder - but that's another bug.
Found by testing and not verified to actually apply the optimizations.
There's still an issue that we need to copy the PlugIns folder
CHANGELOG: MacOS: Fix building Jamulus via Xcode
Context: Fixes an issue?
Fixes: #1841 (at least partly)
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review.
What is missing until this pull request can be merged?
Open another bug on the PlugIn bug.
Checklist