Define JACK headers and sources globally and add some documentation #3046
Define JACK headers and sources globally and add some documentation #3046ann0see merged 2 commits intojamulussoftware:mainfrom
Conversation
Jamulus.pro
Outdated
|
|
||
| # Add include paths and headers for new audio APIs here | ||
|
|
||
| # ASIO |
There was a problem hiding this comment.
I'd split this into two parts:
- provided by the SDK
- "part of Jamulus"
There was a problem hiding this comment.
I'd also make all the variable definitions be either
VARNAME =
or
VARNAME = value
depending on the config that makes them relevant.
ann0see
force-pushed
the
addJamulusProVars
branch
from
730be46 to
3fd0f3a
Compare
ann0see
force-pushed
the
addJamulusProVars
branch
from
3fd0f3a to
cb4867f
Compare
I'm not sure if you misunderstood or forgot a commit here but this doesn't look to have done what I suggested. |
|
Hmm. Then I misunderstood you. I thought you were referring to splitting the ASIO part out to another variable? Can you please provide a suggestion what you'd like to see? |
Jamulus.pro
Outdated
| # Oboe | ||
| HEADERS_OBOE = src/sound/oboe/sound.h | ||
| SOURCES_OBOE = src/sound/oboe/sound.cpp \ | ||
| src/android/androiddebug.cpp # TODO: Remove debugging code if no longer needed |
There was a problem hiding this comment.
Should line 97 be done more like
SOURCES_OBOE = src/sound/oboe/sound.cpp
# TODO: Remove debugging code if no longer needed else move to src/sound if part of sound
SOURCES_OBOE += src/android/androiddebug.cpp
|
I'm starting to think this is creating a lot of variables for no benefit. The variables should only be added to the overall HEADERS, etc, variables conditionally - so wouldn't it be better to do this (addding the headers, etc, separately) where that conditional adding of the variables is done? |
ann0see
force-pushed
the
addJamulusProVars
branch
from
cb4867f to
5b6fdbc
Compare
|
@pljones so you mean basically that we should revert this? I think @pgScorpio mainly wanted to get rid of the duplication introduced by the JACK headers. |
Are the variables used in multiple places? Otherwise there's no duplication being removed. |
|
The JACK headers are used for all three main OS. |
OK, so it's probably best done just for the JACK values, right? |
ann0see
force-pushed
the
addJamulusProVars
branch
from
5b6fdbc to
a5c7074
Compare
ann0see
force-pushed
the
addJamulusProVars
branch
from
a5c7074 to
94ae268
Compare
ann0see
changed the title
|
@pljones I've now updated my PR and split it into two commits. I hope that's ok for all. |
|
Looks good. |
pljones
added
refactoring
2 participants
Short description of changes
Instead of using hardcoded paths to the sound files @pgScorpio suggested to use variables. This PR uses global definitions for JACK sources and headers and adds some small comments.
CHANGELOG: Internal: Improved maintainability of Jamulus.pro by using global definitions.
Context: Fixes an issue?
Fixes: #2573
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for testing
What is missing until this pull request can be merged?
Needs whole CI to pass
Checklist
AUTOBUILD: Please build all targets