Remove remaining directory server mentions#2997
Closed
pljones wants to merge 6 commits intojamulussoftware:mainfrom
Closed
Remove remaining directory server mentions#2997pljones wants to merge 6 commits intojamulussoftware:mainfrom
pljones wants to merge 6 commits intojamulussoftware:mainfrom
Conversation
pljones
force-pushed
the
bugfix/WIP-remove-remaining-directory-server-mentions
branch
from
27e49e9 to
323413a
Compare
mcfnord
reviewed
Jan 22, 2023
| | result.countryId | number | The server country ID (see QLocale::Country). | | ||
| | result.welcomeMessage | string | The server welcome message. | | ||
| | result.directoryServer | string | The directory server to which this server requested registration, or blank if none. | | ||
| | result.directoryServer | string | The directory to which this server requested registration, or blank if none. | |
Contributor
There was a problem hiding this comment.
Suggested change
| | result.directoryServer | string | The directory to which this server requested registration, or blank if none. | | |
| | result.directoryServer | string | The directory where this server requested registration, or blank if none. | |
I don't know if this is better. To which is just a bit... witchy.
Collaborator
Author
There was a problem hiding this comment.
The comment should imply a request being sent from the server to the directory. So the "to" helps, I think. That then limits the rest of the phrase...
Contributor
There was a problem hiding this comment.
Albatross, English! To doesn't help when which follows it. It's just a bizarre English construct that ESL readers choke on. Meanwhile, where this server requested registration has no trouble indicating the actor.
mcfnord
reviewed
Jan 22, 2023
pljones
force-pushed
the
bugfix/WIP-remove-remaining-directory-server-mentions
branch
2 times, most recently
from
b14a903 to
0e25aa4
Compare
pljones
force-pushed
the
bugfix/WIP-remove-remaining-directory-server-mentions
branch
from
0e25aa4 to
3dfa82e
Compare
pljones
force-pushed
the
bugfix/WIP-remove-remaining-directory-server-mentions
branch
from
3dfa82e to
a323d1c
Compare
pljones
deleted the
bugfix/WIP-remove-remaining-directory-server-mentions
branch
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
This is a "Work in progress" -- on the basis I'm not 100% sure I've found all reference still!
CHANGELOG: Further clean up source references to "directory server" to current terminology
Context: Fixes an issue?
We now refer to "directory server" as "Directory" in the documentation. This change tries to find more places the software gets it wrong and correct them.
Does this change need documentation? What needs to be documented and how?
Yes - the help string changes, as well as more translations being added.
Status of this Pull Request
I've run in client, server and directory modes successfully.
What is missing until this pull request can be merged?
Works for me ... but yes, checking the changes - and impact on translators especially - would be useful.
Checklist