Autobuild: Minimize permissions in CI#2953
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom Nov 16, 2022
Merged
Conversation
ann0see
commented
Nov 1, 2022
ann0see
force-pushed
the
autobuild/hardenCI
branch
from
b97271f to
21c0dd4
Compare
ann0see
force-pushed
the
autobuild/hardenCI
branch
from
21c0dd4 to
1ce81d3
Compare
hoffie
approved these changes
Nov 7, 2022
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Thanks, looks good to me!
Did you try to build a test release on your repo with that logic in place? If not, it would be good to do so. :)
Member
Author
|
I needed to set it as visible. |
Member
Author
|
@pljones Could you please review this? |
pljones
approved these changes
Nov 16, 2022
Collaborator
pljones
left a comment
pljones
left a comment
There was a problem hiding this comment.
Happy this grants no more than enough. And happy it'll fail fast if it's not enough 😃.
Member
Author
|
Now the other files also need updates :-). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Reduces permissions in autobuild.yml to a bare minimum.
CHANGELOG: Internal: Reduced permissions in Autobuild for security hardening
Context: Fixes an issue?
Related: #1737
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
Ready for review. Artifacts are building for a release: https://github.com/ann0see/jamulus/actions/runs/3373043380 and seem to be ok. My repo has now enabled strict read only default permissons.
What is missing until this pull request can be merged?
Review
Checklist