Code: Make copy constructor/assignments explicit#2946
Merged
hoffie merged 1 commit intojamulussoftware:masterfrom Nov 7, 2022
Merged
Conversation
C++11 recommends that. When not doing it, newer compiler versions will warn about that. Also see https://en.wikipedia.org/wiki/Rule_of_three_(C%2B%2B_programming) Fixes: jamulussoftware#2681
hoffie
force-pushed
the
autobuild-compiler-warning-copy-constructor
branch
from
ca61c76 to
dfd27ea
Compare
softins
approved these changes
Oct 31, 2022
Member
softins
left a comment
softins
left a comment
There was a problem hiding this comment.
I probably don't qualify as really experienced at C++, but it looks good to me!
pljones
approved these changes
Nov 4, 2022
Collaborator
pljones
left a comment
pljones
left a comment
There was a problem hiding this comment.
My level of C++ is below knowing what this does. Approving as the compiler says yes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
C++ recommends explicitly defining copy constructors when copy assignment operators are defined and vice versa. When not doing it, newer compiler versions will warn about that.
Also see https://en.wikipedia.org/wiki/Rule_of_three_(C%2B%2B_programming)
A test build shows that this change avoids the previously seen warnings on master.
CHANGELOG: Internal: Fix C++ build warnings regarding copy constructor and assignment functions
Context: Fixes an issue?
Fixes: #2681
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
What is missing until this pull request can be merged?
Thorough review by someone who is really experienced with C++ ;)
Checklist