Translations update from Hosted Weblate by weblate · Pull Request #2856 · jamulussoftware/jamulus

weblate · 2022-09-15T15:57:14Z

Translations update from Hosted Weblate for Jamulus/Jamulus app.

It also includes following components:

Jamulus/Windows Installer

Current translation status:

ann0see

@comradekingu please approve your translations such that they don’t show up as unfinished.

comradekingu · 2022-09-17T12:08:44Z

@ann0see I do that so I know what I am unsure about. Mostly I do it to keep track of what source strings need fixing.

ann0see · 2022-09-17T12:45:06Z

@jujudusud great. It's just that it would be good to have one approver per language before it gets merged.

comradekingu · 2022-09-17T14:38:58Z

@ann0see
If you want to review everything I have done, run it through auto-translation.
The quality of the source strings isn't good enough to warrant complaining about anyone else.
Removing the "needs editing" flags makes it much harder for me to change that.

ignotus666 · 2022-09-17T14:54:03Z

@comradekingu
What's so terribly wrong with the source strings? Could you give some examples? Sure some strings could possibly be made clearer, but you do seem to sound quite dismissive of them as a whole, as if they're so bad a proper translation isn't possible. You're the first translator to raise this as an obstacle for translating.

ann0see · 2022-09-17T20:49:31Z

If you want to review everything I have done, run it through auto-translation.

No need for that. Usually we let the translators decide and ask for other potential reviewers if they exist to spot spelling mistakes etc. If you're not yet ok with some translations that's totally fine (the translator is mostly in charge of his/her own translation anyway). As soon as we reach release candidate stage, the existing strings should be "releasable".

ann0see · 2022-09-17T20:54:38Z

What's so terribly wrong with the source strings?

I think there are some unclear strings - at least I find some once in a while.
Best would be to raise an issue and list them with a suggestion + explanation what needs fixing

trebmuh

👍

ann0see · 2022-09-18T20:05:01Z

Review checklist:

Translator listed in the src/util.cpp optionally add link to PR or code (todo: Add kingu and invite to matrix/discord)
Punctuation and spacing consistent
Signal words consistent ("ASIO", "Buffer")
App translations: No untranslated strings (grep unfinished -5 src/translation/translation_$TRANSLATION*.ts) (not to be checked in this stage)
App translations: Only a single .ts file checked in (.qm in addition is also OK)

ann0see

Thanks all! Just a few comments

ann0see · 2022-09-18T20:11:04Z

src/translation/translation_nb_NO.ts

        <location filename="../audiomixerboard.cpp" line="250"/>
        <source>Pan</source>
-        <translation type="unfinished"></translation>
+        <translation>Panorering</translation>


I'd check how this looks in the app @comradekingu since Panorering might be too big.

Yes, the label wants to be as small as possible.

There is a https://docs.weblate.org/en/latest/user/checks.html?highlight=max#maximum-length-of-translation
available.
I think it is also possible to take into account how that factors into the given font used, but a sensible limit helps sort this for now.

ann0see · 2022-09-18T20:13:16Z

src/translation/translation_nb_NO.ts

        <location filename="../clientdlg.cpp" line="288"/>
        <source>&amp;Load Mixer Channels Setup...</source>
-        <translation type="unfinished"></translation>
+        <translation type="unfinished">&amp;Last inn kanalmikserinnstillingene …</translation>


Good point about the typography here. Should the source string also use … instead of three dots?

Using special typography should, in my view, be avoided. I don't know how a screen reader would render the special character, for example. Using ... to indicate a menu item opens a new window is pretty standard, too - not following that might also cause accessibility issues. I think it doesn't look good, either.

@pljones
The error here is the missing hyphen(s), and/or prepositions.
The translation is ~"Load the settings for the channel mixer", which I got from looking at the Swedish string.

The use of an ellipsis is correct, insofar as both typography and current paradigms in software go.
A screen reader will not output "dot" "dot" "dot", which is annoying and wastes time.
The ellipsis is the correct character to use, and Weblate triggers and error when this isn't the case.
If it doesn't look good for you, it is possible to change the font used.

https://develop.kde.org/hig/style/writing/placeholder/
https://developer.gnome.org/hig/guidelines/typography.html
https://wiki.amigaos.net/wiki/UI_Style_Guide_Menus#Ellipsis
https://www.stylemanual.gov.au/grammar-punctuation-and-conventions/punctuation-and-capitalisation/ellipses#do_not_use_a_string_of_full_stops
https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/e/ellipsis-button
(and so on)

The ellipsis does not create issues unless UTF-8 support is missing.

ann0see · 2022-09-18T20:14:42Z

src/translation/translation_nb_NO.ts

        <location filename="../clientdlgbase.ui" line="557"/>
        <source>MUTED (Other people won&apos;t hear you)</source>
-        <translation type="unfinished"></translation>
+        <translation type="unfinished">Forstummet (andre hører deg ikke)</translation>


I think Forstummet should also be all caps to reassemble the English version

I don't really want to resemble the English version.
The nb_NO one is consistent, and the user needs never know the English one does anything differently.

https://www.compart.com/en/unicode/search?q=speaker#characters or something like
a crossed out person talking, a crossed out speech bubble, etc. would work. I think that is what others do.

The warning is basically a hack anyway. Yes, the microphone would be a valid option too.

Probably we’ll then leave it as you suggested.

ann0see · 2022-09-18T20:16:55Z

src/translation/translation_nb_NO.ts

        <location filename="../serverdlg.cpp" line="245"/>
        <source>&amp;Hide %1 server</source>
-        <translation type="unfinished"></translation>
+        <translation></translation>


That's strange: Why is it an empty string?

@hoffie probably some future translation CI script should validate that too.

It could be flagged "read only" in Weblate to avoid it for now.

But is it a read only string?

@comradekingu: you just seem to have forgotten to translate this string, don't you?

@trebmuh
https://hosted.weblate.org/translate/jamulus/jamulus-app/nb_NO/?checksum=bd82c5a091ec5c9c
From memory I was unsure if "%1" is a numeral or the name of a server.
Hence the question https://hosted.weblate.org/translate/jamulus/jamulus-app/nb_NO/?checksum=bd82c5a091ec5c9c
"Is this a known server (name), or is it an amount of servers?"

Then you decided to leave it in English?
If so, that's a better idea IMHO to leave the translation "empty" then it's still marked "unfinished" and fall back to display it in English.

ann0see · 2022-09-18T20:17:55Z

src/translation/translation_nb_NO.ts

        <location filename="../serverdlg.cpp" line="870"/>
        <source>ERROR</source>
-        <translation type="unfinished"></translation>
+        <translation type="unfinished">Feil</translation>


As above: probably this should be all caps.

I am of the opinion that nothing should ever be all caps.

https://developer.gnome.org/hig/guidelines/typography.html "Do not capitalize every letter (all caps)."
https://developers.google.com/style/capitalization (says sentence case).
https://develop.kde.org/hig/style/writing/capitalization/ doesn't mention even doing all caps.

ann0see · 2022-09-18T20:18:41Z

src/translation/translation_pt_PT.ts

        <location filename="../aboutdlgbase.ui" line="72"/>
        <source>Copyright (C) 2005-2022 The Jamulus Development Team</source>
-        <translation>Copyright (C) 2005-2022 A Equipa de Desenvolvimento do Jamulus</translation>
+        <translation>Direitos de Autor (C) 2005-2022 A Equipa de Desenvolvimento do Jamulus</translation>


Just as small comment, this doesn't need to be translated

Maybe true, but it should be a "©" and an en-dash "–⁠" https://www.thepunctuationguide.com/en-dash.html
I don't really know if RTL languages run the name on the right or not, but it is possible.
In languages that never use latin script it needs to be translatable.

src/translation/translation_es_ES.ts

comradekingu · 2022-09-19T15:26:11Z

@ignotus666 The source strings aren't too far off, but I'd rather do something about it.
This way it becomes far easier to translate Jamulus for yet others.
I don't have a lot of time, but I'll have a look and see what files need changing to update the source strings correctly.

ann0see

Approving as this must go in ASAP, before the translators not knowing or using weblate yet might get conflicts.

pljones · 2022-10-02T07:35:51Z

src/translation/translation_de_DE.ts

        <location filename="../serverdlg.cpp" line="67"/>
        <source>For any value except &apos;%1&apos;, this server registers with a directory so that a %2 user can select this server in the client connect dialog server list when they choose that directory.</source>
-        <translation type="unfinished"></translation>
+        <translation>Bei jedem Wert außer &apos;%1&apos; registriert sich dieser Server bei einem Verzeichnis, so dass ein %2-Benutzer diesen Server in der Serverliste des Client-Verbindungsdialogs auswählen kann, sobald er dieses Verzeichnis wählt.</translation>


Consistency: " above, ' here.

pljones · 2022-10-02T07:37:00Z

src/translation/translation_de_DE.ts

    </message>
    <message>
        <location filename="../serverdlg.cpp" line="67"/>
        <source>For any value except &apos;%1&apos;, this server registers with a directory so that a %2 user can select this server in the client connect dialog server list when they choose that directory.</source>


As above, English and translations should use "‘" ‘ and "’" ’. (This means you get language and font-specific rendering of the opening and closing quote marks. "“" “ and "”" ” might be preferable.)

This is a squashed commit for one language translated on Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: 이정희 <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/jamulus-app/ko/ Translate-URL: https://hosted.weblate.org/projects/jamulus/windows-installer/ko/ Translation: Jamulus/Jamulus app Translation: Jamulus/Windows Installer

This is a squashed commit for one language translated on Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Manuela Silva <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/jamulus-app/pt_PT/ Translate-URL: https://hosted.weblate.org/projects/jamulus/windows-installer/ Translate-URL: https://hosted.weblate.org/projects/jamulus/windows-installer/pt_PT/ Translation: Jamulus/Jamulus app Translation: Jamulus/Windows Installer

Updated by "Squash Git commits" hook in Weblate. Translation: Jamulus/Windows Installer Translate-URL: https://hosted.weblate.org/projects/jamulus/windows-installer/

ann0see · 2022-10-10T19:17:42Z

@hoffie yes, @comradekingu is missing in the utils.h file, as far as I know.

ann0see added this to the Release 3.9.1 milestone Sep 17, 2022

ann0see requested review from ignotus666 and jujudusud September 17, 2022 09:41

ann0see reviewed Sep 17, 2022

View reviewed changes

jujudusud approved these changes Sep 17, 2022

View reviewed changes

trebmuh approved these changes Sep 18, 2022

View reviewed changes

ann0see requested review from ann0see and hoffie September 18, 2022 20:05

ann0see reviewed Sep 18, 2022

View reviewed changes

ann0see approved these changes Sep 21, 2022

View reviewed changes

ignotus666 approved these changes Sep 21, 2022

View reviewed changes

ann0see requested a review from pljones September 21, 2022 12:08

pljones reviewed Oct 2, 2022

View reviewed changes

pljones mentioned this pull request Oct 2, 2022

Include HTML in strDirectoryTypeWT #2894

Merged

5 tasks

pljones assigned melcon, SeeLook, jose1711, ignotus666, jerogee, Snayler, jujudusud, henkdegroot, dzpex, rolamos, comradekingu, genesisproject2020 and BLumia and unassigned henkdegroot, comradekingu, ignotus666 and jujudusud Oct 3, 2022

jerogee approved these changes Oct 4, 2022

View reviewed changes

pljones unassigned jerogee Oct 4, 2022

weblate and others added 3 commits October 7, 2022 09:03

Update translation files

d8160bf

Updated by "Squash Git commits" hook in Weblate. Translation: Jamulus/Windows Installer Translate-URL: https://hosted.weblate.org/projects/jamulus/windows-installer/

pljones approved these changes Oct 9, 2022

View reviewed changes

pljones merged commit 24ac331 into jamulussoftware:master Oct 9, 2022

This was referenced Oct 9, 2022

Ensure correct quoting in translations #2902

Open

Use © symbol in Copyright screen #2903

Closed

Comments

Conversation

weblate commented Sep 15, 2022

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

Uh oh!

comradekingu commented Sep 17, 2022

Uh oh!

ann0see commented Sep 17, 2022

Uh oh!

comradekingu commented Sep 17, 2022

Uh oh!

ignotus666 commented Sep 17, 2022

Uh oh!

ann0see commented Sep 17, 2022

Uh oh!

ann0see commented Sep 17, 2022

Uh oh!

trebmuh left a comment

Choose a reason for hiding this comment

Uh oh!

ann0see commented Sep 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pljones Sep 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ann0see Sep 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

comradekingu Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

comradekingu commented Sep 19, 2022

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

Uh oh!

ann0see commented Sep 18, 2022 •

edited

Loading

pljones Sep 18, 2022 •

edited

Loading

ann0see Sep 18, 2022 •

edited

Loading

comradekingu Sep 19, 2022 •

edited

Loading

pljones Oct 2, 2022 •

edited

Loading