Refactoring: Move images to src/res (Windows and Mac)#2834
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom Sep 5, 2022
Merged
Refactoring: Move images to src/res (Windows and Mac)#2834ann0see merged 1 commit intojamulussoftware:masterfrom
ann0see merged 1 commit intojamulussoftware:masterfrom
Conversation
ann0see
changed the title
ann0see
force-pushed
the
move/moveImages
branch
from
88b5785 to
70d69da
Compare
Collaborator
Part of me still wants to be able to glance at the resources and know what they're for (i.e. used in Jamulus on platform X, used in the installer on platform Y, etc). So it might be good to take this opportunity to improve the naming for clarity, as well as moving them. |
ann0see
force-pushed
the
move/moveImages
branch
from
70d69da to
db82f60
Compare
ann0see
force-pushed
the
move/moveImages
branch
from
db82f60 to
314abce
Compare
Member
Author
|
Ok. Once this is finished, we need to re-test macOS and Windows icons. |
pljones
approved these changes
Sep 4, 2022
Collaborator
pljones
left a comment
pljones
left a comment
There was a problem hiding this comment.
Approving. Not sure why the ARMHF build wasn't happy.
Member
Author
|
I've opened #2837 |
Member
Author
Done and they still show up correctly. |
hoffie
approved these changes
Sep 4, 2022
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Looks sane, grep didn't find any more mentions of the old file names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Moves images from their OS folders to src/res. Note: Android and Linux will follow since they seem to be more complicated.
CHANGELOG: Refactoring: Moved around files to clean up the repository
Context: Fixes an issue?
Related to: #2601
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready review. Unfortunately due to #1841 I can't test it locally on macOS, but I tested the CI version.
What is missing until this pull request can be merged?
Nothing
Checklist