Fix new channel with no info not being displayed.#2774
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom Aug 9, 2022
Merged
Fix new channel with no info not being displayed.#2774ann0see merged 1 commit intojamulussoftware:masterfrom
ann0see merged 1 commit intojamulussoftware:masterfrom
Conversation
A new connection must always cause a channel update signal to be emitted, even if the channel info for the new channel is empty. Fixes jamulussoftware#2754
hoffie
approved these changes
Aug 9, 2022
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Thanks!
Approving based on code, I'm planning to run some additional tests in the coming days.
ann0see
approved these changes
Aug 9, 2022
Member
|
Merged due to potential privacy issues. (I've tested it a few days ago). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
A new connection must always cause a channel update signal to be emitted,
even if the channel info for the new channel is empty.
CHANGELOG: Bug: Correct new channel not being shown to others if it connects with null channel info.
Context: Fixes an issue?
Fixes #2754
Does this change need documentation? What needs to be documented and how?
No, bug fix only
Status of this Pull Request
Tested and ready for merge
What is missing until this pull request can be merged?
Checklist