Translations: Add Korean to language selection#2741
Translations: Add Korean to language selection#2741pljones merged 2 commits intojamulussoftware:masterfrom
Conversation
|
Surely! |
ann0see
left a comment
There was a problem hiding this comment.
Looks good. However waiting for test by @bagjunggyu
src/resources.qrc
Outdated
| <qresource prefix="/translations"> | ||
| <file alias="translation_zh_CN">translation/translation_zh_CN.qm</file> | ||
| </qresource> | ||
| <qresource prefix="/translations"> |
There was a problem hiding this comment.
Strange. I thought I did that... nevertheless thanks.
0061d95 to
a65ec77
Compare
|
@bagjunggyu Thanks for confirming! |
|
I don't think we have a guide. Tony or Ignotus might have written something up, but I doubt it. |
|
Given we've just done it for Korean, it might be worth writing one now before the memories fade away. |
Certainly. I just don't have the energy to push that forward atm, which is why I chose to add at least a small reminder/comment to avoid forgetting this very step in the future. A proper checklist would obviously be even better. @pljones Feel free to merge on approval. |
|
It was my foot step. Jamulus Internationalization Translator's
Dev team's
|
|
@bagjunggyu can you edit The TRANSLATION.md file in the docs/ folder and write up a short paragraph what needs to be done (you can pair up with @gilgongo (our "documentation guy") |

Short description of changes
CHANGELOG: Translation: Added Korean translation to Jamulus
Context: Fixes an issue?
Fixes: #2740 #2714
Related: #2685
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
Ready.
What is missing until this pull request can be merged?
Reviews.
@bagjunggyu Could you check the release artifacts from this PR?
Checklist