Skip to content

Comments

Update pl_PL app translation for 3.9.0#2735

Merged
pljones merged 2 commits intojamulussoftware:masterfrom
SeeLook:translation_pl_PL_v3.9.0
Jul 23, 2022
Merged

Update pl_PL app translation for 3.9.0#2735
pljones merged 2 commits intojamulussoftware:masterfrom
SeeLook:translation_pl_PL_v3.9.0

Conversation

@SeeLook
Copy link
Contributor

@SeeLook SeeLook commented Jul 17, 2022 •
edited by pljones
Loading

Fixes #2697

Short description of changes

CHANGELOG:

Context: Fixes an issue?

Does this change need documentation? What needs to be documented and how?

Status of this Pull Request

What is missing until this pull request can be merged?

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@pljones
Copy link
Collaborator

pljones commented Jul 17, 2022 •
edited
Loading

Thanks!

Do we have anyone who can review this?

@ann0see
Copy link
Member

ann0see commented Jul 17, 2022 •
edited
Loading

Review Checklist:

  • Translator listed in the src/util.cpp

    jamulus/src/util.cpp

    Line 724 in fa204ad

    "<p>Tomasz Bojczuk (<a href=\"https://github.com/SeeLook\">SeeLook</a>)</p>"
  • Punctuation and spacing consistent
  • Signal words consistent ("ASIO", "Buffer")
  • App translations: No untranslated strings (grep unfinished -5 src/translation/translation_$TRANSLATION*.ts)
  • App translations: Only a single .ts file checked in (.qm in addition is also OK)

ann0see
ann0see reviewed Jul 17, 2022
View reviewed changes
@ann0see
Copy link
Member

ann0see commented Jul 17, 2022

@SeeLook this also needs to be rebased to fix the conflicts: https://github.com/jamulussoftware/jamulus/blob/master/docs/TRANSLATING.md#updating-a-prfixing-conflicts

@SeeLook SeeLook force-pushed the translation_pl_PL_v3.9.0 branch from f43f363 to 95fe105 Compare July 17, 2022 15:41
@ann0see ann0see requested a review from pljones July 20, 2022 21:16
pljones
pljones reviewed Jul 21, 2022
View reviewed changes
src/translation/translation_pl_PL.ts Outdated
<location filename="../connectdlg.cpp" line="87"/>
<source>If you know the server address, you can connect to it using the Server name/Address field. An optional port number can be added after the server address using a colon as a separator, e.g. %1. The field will also show a list of the most recently used server addresses.</source>
<translation type="unfinished"></translation>
<translation>Jeżeli znasz adres adres serwera możesz podłączyć się do niego podając te dane w polu nazwa/adres serwera. Dodatkowo może być podany numer portu - po dwukropku za adresem/numerem IP, np. %1. To pole tekstowe będzie także wyświetlać listę ostatnio używanych adresów.</translation>
Copy link
Collaborator

@pljones pljones Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeżeli znasz adres adres serwera możesz podłączyć -- adres is duplicated?

Copy link
Contributor Author

@SeeLook SeeLook Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

pljones
pljones reviewed Jul 21, 2022
View reviewed changes
src/translation/translation_pl_PL.ts
<location filename="../serverdlg.cpp" line="195"/>
<source>Custom Directory address</source>
<translation type="unfinished"></translation>
<translation>Własny adres serwera zbiorczego</translation>
Copy link
Collaborator

@pljones pljones Jul 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The English doesn't contain the word "server", so this is wrong.

Please read up on the explanation around Client, Server and Directory usage within the documentation.

Copy link
Contributor Author

@SeeLook SeeLook Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can translate English word 'Directory' directly into Polish but this is very general, technical and says nothing about.
So I used Polish „Serwer zbiorczy” which describes 'Directory' more precise.

Copy link
Collaborator

@pljones pljones Jul 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's meant to mean the same as "address book", like where you'd keep names and addresses. Nothing technical about it.

@pljones pljones added this to the Release 3.9.0 milestone Jul 22, 2022
@pljones pljones added the translation used by tools/create-translation-issues.sh label Jul 22, 2022
@ann0see
Copy link
Member

ann0see commented Jul 22, 2022

@pljones would you be ok with a merge of this PR despite the open comment?

@pljones
Copy link
Collaborator

pljones commented Jul 22, 2022

I'll leave it for today. If @SeeLook can fix the various references by tomorrow, we can merge. I'd rather get them consistent.

@pljones pljones mentioned this pull request Jul 23, 2022
Closed
75 tasks
@pljones pljones merged commit 5f2a67d into jamulussoftware:master Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pljones pljones pljones left review comments

@ann0see ann0see ann0see approved these changes

Assignees

No one assigned

Labels

translation used by tools/create-translation-issues.sh

Projects

None yet

Milestone

Release 3.9.0

Development

Successfully merging this pull request may close these issues.

Update pl_PL app translation for 3.9.0

3 participants

@SeeLook @pljones @ann0see