Fixes #2709: reword status to say "directory"#2710
Merged
pljones merged 2 commits intojamulussoftware:masterfrom Jul 5, 2022
Merged
Fixes #2709: reword status to say "directory"#2710pljones merged 2 commits intojamulussoftware:masterfrom
pljones merged 2 commits intojamulussoftware:masterfrom
Conversation
jujudusud
reviewed
Jul 4, 2022
ann0see
reviewed
Jul 5, 2022
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
As it requires translation we need to tell the translators...
Collaborator
Author
|
That's what triggered this -- seeing it in translation strings. |
ann0see
approved these changes
Jul 5, 2022
Member
|
I'd merge it as soon as possible and notify translators |
jujudusud
approved these changes
Jul 5, 2022
jujudusud
approved these changes
Jul 5, 2022
hoffie
approved these changes
Jul 5, 2022
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
- Should this PR also include updated files as produced by
lupdate? Or did you avoid adding them intentionally? - Merging this PR now will add additional work:
- PRs where the translation was already updated despite the source string only changing here will likely show up for translation again.
- PRs which are based on a commit which did not have this change are likely to have a conflict. The conflict can only be solved by the translator and not by maintainers.
I already saw that you (@pljones) have been mentoring some (all?) already submitted translation PRs, so I guess it'll be taken care of. Therefore, approving.
Collaborator
Author
|
I left out the lrelease stuff to do separately with a new push to the translators. Once I've done that to master, I'll update all the translator issues, re-opening where necessary. |
pljones
added a commit
that referenced
this pull request
Jul 5, 2022
This was referenced Jul 5, 2022
ghost
mentioned this pull request
melcon
added a commit
to melcon/jamulus
that referenced
this pull request
Jul 21, 2022
Fixed the translation for jamulussoftware#2710 that got messed up during the branching/fetch/merge. This is the last one for pt_BR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Fixes three of the remaining references to "directory server" rather than "directory" in the code -- these are in messages, two of them requiring translation.
There is one I didn't change:
--directoryserver. I could change that, too.There's a whole load of others in the code that don't get seen - those need changing, too, really, but not as part of this fix.
CHANGELOG: Fix (hopefully) all remaining references to "directory server" in displayed messages to say "directory"
Context: Fixes an issue?
Fixes: #2709
Does this change need documentation?
Hopefully all documentation already refers to "directory" correctly.
Status of this Pull Request
Need to confirm scope.
What is missing until this pull request can be merged?
Decide when to merge it.
Checklist