Update es_ES app translation for 3.9.0#2706
Conversation
src/translation/translation_es_ES.ts
Outdated
| <location filename="../serverdlg.cpp" line="73"/> | ||
| <source>The registration of the server is renewed periodically to make sure that all servers in the connect dialog server list are actually available.</source> | ||
| <translation type="unfinished"></translation> | ||
| <translatorcomment>El registro del servidor se renueva periódicamente para asegurarse de que todos los servidores en la lista de servidores en la ventana de conexión están realmente disponibles.</translatorcomment> |
There was a problem hiding this comment.
Why did you translate a comment and left the translation empty? Is this an error?
There was a problem hiding this comment.
Argh! It's happened to me before... Typed into the wrong field. Fixed.
There was a problem hiding this comment.
Typed into the wrong field.
Just for info, what tool are you using?
|
All looks good to me - do we have someone else who can check the Spanish? (I can only "scan read" - it's close enough to English ;).) |
There was a problem hiding this comment.
- Translator listed in the
src/util.cpp - Punctuation and spacing consistent (todo)
- Signal words consistent ("ASIO", "Buffer") (todo)
- No untranslated strings (
grep unfinished -5 src/res/translation/translation_$TRANSLTION*.ts) - Only a single
.tsfile checked in (+ Installer translations)
|
Should still be squash merged ;-) |
|
The problem with Github squash-commit is that it doesn't squash merge - it squashes to a single, non-merge, commit on master. |
|
Hmm. Yes. So you say it should be squashed locally and then merged? |
|
It needs a rebase -i, the squash/fix whatever on the commits, then merge. I was going to do it locally, yeah, the push directly. It's one of Github's little annoyances. (Basically, you can't go editing the collaborator's repo, which is fair enough; you can pull their branch to a branch, then squash on that branch, though...) |
3 participants
Short description of changes
Update es_ES app translation for 3.9.0
CHANGELOG: Updated Spanish translation of app for 3.9.0
Context: Fixes an issue?
Fixes #2693
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready to be merged
What is missing until this pull request can be merged?
Checklist