Autobuild: Add macOS M1 (arm64) build target#2682
Merged
pljones merged 1 commit intojamulussoftware:masterfrom Jul 6, 2022
Merged
Autobuild: Add macOS M1 (arm64) build target#2682pljones merged 1 commit intojamulussoftware:masterfrom
pljones merged 1 commit intojamulussoftware:masterfrom
Conversation
hoffie
added
the
needs documentation
6 tasks
ann0see
reviewed
Jul 1, 2022
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Thanks. I'd need someone with a M1 Mac...
Can you ping the person who requested it?
| BUILD_ARGS=("-s" "${MACOS_CERTIFICATE_ID}") | ||
| fi | ||
| ./mac/deploy_mac.sh "${BUILD_ARGS[@]}" | ||
| TARGET_ARCH="${TARGET_ARCH}" ./mac/deploy_mac.sh "${BUILD_ARGS[@]}" |
Member
There was a problem hiding this comment.
Didn't read the code further, but would it be possible to pass the arch by normal arguments, not environment variables to stay consistent?
Member
|
Yes, I'd like to get it in for the next release 3.9.0 |
ann0see
approved these changes
Jul 3, 2022
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Since we have positive reviews with M1 compatibility, approving. My comment still stands (from above)
Member
|
@emlynmac could you please Review this PR? I think it's ok. |
Member
|
@pljones Can we merge this? I'd like to start documenting this |
Collaborator
|
I've no issue with it (I tend to leave reviewing the build stuff to others :) ). |
pljones
approved these changes
Jul 6, 2022
3 tasks
ann0see
removed
the
needs documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
This PR adds a build target for macOS M1 (arm64).
It does not yet support universal binaries (x86 + arm64 in a single archive). I haven't looked into how much effort this would be. It might still get ready for 3.9.0. If it doesn't, a later release could unify those releases again. In any case, I don't want to do that as part of this PR.
@ann0see I haven't forgotten about the autobuild limiting logic and I'll submit a related PR in the coming days.
CHANGELOG: Build: Add macOS M1 (arm64) support
Context: Fixes an issue?
Related #2357
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist