A11Y: Added name and instrument to accessibility labels for mute, solo, group#2639
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom May 27, 2022
Merged
Conversation
chigkim
force-pushed
the
a11y-labeled-controls
branch
from
4d4840e to
66e7501
Compare
ann0see
approved these changes
May 27, 2022
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Tested on Windows 11 with the integrated screenreader and it works. However the level-meter doesn't (but that's not part of this PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Added name and instrument to accessibility labels for mute, solo, group
CHANGELOG: Accessibility: Added name and instrument to accessibility labels for mute, solo, group
Context: Fixes an issue?
When you tab to land on a control like mute, solo, group, screen reader just says Mute Unchecked. Now it says Mute Bob, Keyboard, Expert, Unchecked, so Users know which person to mute, solo, and etc.
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist