Fix loading serverlist entry from CSV file#2631
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom May 16, 2022
Merged
Fix loading serverlist entry from CSV file#2631ann0see merged 1 commit intojamulussoftware:masterfrom
ann0see merged 1 commit intojamulussoftware:masterfrom
Conversation
ann0see
approved these changes
May 16, 2022
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Approving on the assumption it is well tested (looks trivial)
hoffie
approved these changes
May 16, 2022
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Heh, in hindsight the fix looks obvious... ;)
Collaborator
Author
|
Yeah, I was testing something else and kept seeing this truncation happening. Eventually looked at this bit of the code and went "...D'uh..." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
The server list persistence code has a but that causes corruption of the server name and city when the file is read. It truncates the base64-encoded value to the max field length -- before decoding it
This fixes the code to truncate after decoding.
CHANGELOG: Fix loading of persistent server list entries
Context: Fixes an issue?
See above.
Does this change need documentation? What needs to be documented and how?
No. Fix for existing feature.
Status of this Pull Request
Test and running on all my directories.
What is missing until this pull request can be merged?
Approvals.
Checklist