Refactoring: Remove "Jamulus" from translated texts#2609
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom May 15, 2022
Merged
Refactoring: Remove "Jamulus" from translated texts#2609ann0see merged 1 commit intojamulussoftware:masterfrom
ann0see merged 1 commit intojamulussoftware:masterfrom
Conversation
We will read the app name from the APP_NAME constant now.
Member
Author
hoffie
approved these changes
May 1, 2022
Member
|
Not entirely sure if it's a sane idea, but maybe give it a thought: Would it make sense to update .ts files centrally here? Is it possible at all (thinking of Chinese)? |
Member
Author
|
I‘d rather not do it. We can always do that in the translation cycle |
Member
Author
|
@gilgongo, that's another one. |
Member
Author
|
@gilgongo in favour of getting these PRs merged, could you please review? |
Member
Author
|
@henkdegroot I think this PR is an easy one to review;-) |
henkdegroot
approved these changes
May 15, 2022
Contributor
henkdegroot
left a comment
henkdegroot
left a comment
There was a problem hiding this comment.
Changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Removes found occurances of "Jamulus" throughout the code.
We will read the app name from the APP_NAME constant now.
CHANGELOG: Refactoring: Removed occurrences of plain name "Jamulus" in translatable texts.
Context: Fixes an issue?
Fixes: #2354
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready for review.
What is missing until this pull request can be merged?
Nothing.
Checklist