Remove translation from CLI version text#2602
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom May 19, 2022
Merged
Conversation
Contributor
Author
|
Sample of the CLI version output in windows:
|
ann0see
reviewed
Apr 19, 2022
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Thanks! One time we should also add the uses ASIO/copyright statement conditionally.
ann0see
approved these changes
Apr 19, 2022
Contributor
Author
|
Asio text to be added as part of the Asio PR I will be doing for updating the installer and About dialog. |
henkdegroot
force-pushed
the
remove-translation-cli
branch
from
7ef5603 to
91b39a7
Compare
Member
|
@hoffie could you please review this PR? |
pljones
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Remove the translation for the CLI version text output
CHANGELOG: Client: Remove the translation for the CLI version text output
Context: Fixes an issue?
Fixes #2319
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Waiting on second review
What is missing until this pull request can be merged?
Nothing
Checklist