Merged
Conversation
ann0see
force-pushed
the
patch/updateAqt
branch
2 times, most recently
from
59d14e6 to
4882cd2
Compare
hoffie
approved these changes
Apr 14, 2022
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Thanks. You beat me to it... :)
Note: CodeQL is in a state which I've never seen, but I don't think it can be related to this PR.
Collaborator
|
Has CodeQL got out of sync somehow? The MacOS Legacy build ran the CodeQL check -- is that right? Is a rebase needed? |
ann0see
force-pushed
the
patch/updateAqt
branch
from
4882cd2 to
1d499a7
Compare
Member
Author
|
Rebased. Let's have a look what CodeQl does. |
Member
Author
Yes. That should be ok due to the signing issue we tried to fix? |
Collaborator
|
Better :) |
pljones
approved these changes
Apr 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Updates aqt to the latest version
CHANGELOG: Internal: Updated aqt to v2.1.0 due to reliability reasons
Context: Fixes an issue?
Not really, but includes @hoffie 's updated mirror list.
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Just an autobuild test.
Checklist