Autobuild: Clean up redundant variables in workflow definition#2584
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom Apr 9, 2022
Merged
Autobuild: Clean up redundant variables in workflow definition#2584ann0see merged 1 commit intojamulussoftware:masterfrom
ann0see merged 1 commit intojamulussoftware:masterfrom
Conversation
c08811b to
89b67f0
Compare
pljones
approved these changes
Apr 9, 2022
22 tasks
This was referenced Jun 18, 2022
Member
Author
|
Somehow this PR lost most of the supposed content before merge (maybe due to a bad rebase). I'll re-submit what's left. |
5 tasks
hoffie
added a commit
that referenced
this pull request
Jun 19, 2022
Autobuild: Improve and reorganize git/Changelog scripts (re-submission of #2584)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Autobuild: Don't hardcode python path in analyse_git_reference.pyAutobuild: Move Changelog generation to the workflowPreviously, the autobuild changelog (autoLatestChangelog.md) which is used for the Github release body, was generated as part of the "analyse_git_reference.py" script. It does not seem logical for an analysis script to have a side effect of producing a Changelog file. Also, the file name (autoLatestChangelog.md) was hardcoded in two places and had to match (workflow + script).
With this commit, the changelog generation call (.github/actions_scripts/getChangelog.pl) is moved to the workflow. This follows the principle of least surprise and moves the output file name usage to a single file (the workflow).
Autobuild: Improve variable naming/coding style in analyse_git_reference.pyAutobuild: Move .github/action_scripts to .github/autobuildThis also renames the two scripts to better reflect what they do.
Autobuild: Drop redundant github.workspace variable reference in workflow
Edit: This PR lacked most of the changes above. See #2656 for a re-submission with the missing parts.
CHANGELOG: (Autobuild: Clean up redundant variables in workflow definition; to be condensed with other Autobuild refactoring entries)
Context: Fixes an issue?
I think it had been mentioned elsewhere
analyze_somethingscript is not supposed to have the side effect of writing a (Changelog) fileDoes this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready.
What is missing until this pull request can be merged?
Reviews.
Checklist