Global MsgBoxes and Commandline#2583
Closed
pgScorpio wants to merge 11 commits intojamulussoftware:masterfrom
Closed
Global MsgBoxes and Commandline#2583pgScorpio wants to merge 11 commits intojamulussoftware:masterfrom
pgScorpio wants to merge 11 commits intojamulussoftware:masterfrom
Conversation
Member
|
Thanks. If you want, we can use this PR as "learning PR" on Friday? |
Even a clang-format off/on between else and if seems to give problems with clang-format 10.0.0. So I moved the comment with clang-format off/on to before the else. Let's see if this solves the clang-format problem.
Contributor
Author
Well, if we are going to experiment, I prefer not to do that on any of my working branches, but of coarse we always can create a temporary branch to do so. |
Member
Yes sure. But we might also want to touch this one. But let's wait what tomorrow brings ;-) BTW: Congrats the coding style now worked ;-) |
pgScorpio
added a commit
to pgScorpio/jamulus
that referenced
this pull request
Apr 7, 2022
This PR modifies soundbase and all sound implementations at once, because all CSound implementations depend on CSoundbase, so these can't be merged one by one in steps. This first step however still has backwards compatibility to the rest of the code. The second stage steps will be removing the backwards compatibility (which a.o. will improve error handling), so than we need to modify main.cpp, client.cpp and probably some other files too. but this can be done in multiple PR'steps. The third stage steps will be using the new soundproperties functionality which will affect several gui files, but also these changes can be merged in multiple steps. NOTES: Since this PR Needs jamulussoftware#2583 Global MsgBoxes and Commandline to be implemented first, this commit has to include these changes into global.h and main.cpp too. The avoid clang-format issues again this PR also includes a modified settings.cpp.
This was referenced Apr 8, 2022
Member
|
Should this PR be closed in favor of #2598? |
Contributor
Author
pgScorpio
added a commit
to pgScorpio/jamulus
that referenced
this pull request
May 15, 2022
NOTES: Since this PR Needs jamulussoftware#2583 Global MsgBoxes and Commandline to be implemented first, this commit has to include these changes into global.h and main.cpp too. The avoid clang-format issues again this PR also includes a modified settings.cpp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
New attempt replacing #2541
Added global messagebox and commandline parameter parsing classes to global.h/main.c
Adapted all messageboxes to use the new CMsgBoxes class.
CHANGELOG:
Context: Fixes an issue?
General improvement and preparation for sound-redesign.
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist